[BLAS] fix iamin/iamax header to correspond to oneMKL backend#445
Merged
andrewtbarker merged 1 commit intouxlfoundation:developfrom Feb 14, 2024
Merged
Conversation
mkrainiuk
approved these changes
Feb 14, 2024
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The local headers in
src/blas/backends/mkl_common/mkl_blas_backend.hxxcorrespond to deprecated symbols in the oneMKL library backend. When those symbols are removed the oneMKL interfaces will no longer build with the oneMKL backend. This PR fixes the headers to avoid this.Checklist
All Submissions
test.txt
Testing was done with the 2024.0 version of the oneMKL library for the backend. One test (
blas/EXAMPLE/RT/gemm_usm/gpu) fails but it is unrelated to this PR.