Allow spawning multiple prefabs#8
Open
francofusco wants to merge 1 commit into
Open
Conversation
This commit allows to insert any prefab inside a scene, not only gates.
Author
|
Ping! |
Contributor
|
LGTM Thank you for your great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deals with uzh-rpg/flightmare#77. More specifically it slightly changes the
CameraController.csscript so that any prefab in theTemplatesfolder can be spawned. All trailing white spaces in the modified sources were also removed.A demo in flightmare (showing that these changes do work) is being proposed in the sibling PR uzh-rpg/flightmare#125.
@yun-long and @slimeth there are still 2 improvements that I would like to introduce, but I prefer having your feedback first:
Templates, you will get arpg_gateinstead. I would prefer to create a new prefab, e.g., a cube with "404 not found" written on it, and spawn that instead. I think that showing such kind of object makes it much clearer that an error occurred.Cheers!