fix: block bulk delete when selected sessions are hidden by filter#181
Merged
vakovalskii merged 1 commit intoApr 17, 2026
Merged
Conversation
When a user selects sessions then applies a search/filter, some selected sessions become invisible. Previously, Delete would silently remove those hidden sessions too — a data loss risk. Now: - updateBulkBar() detects selected IDs not in filteredSessions - Shows warning: "⚠ N hidden by filter — deselect hidden" (amber) - Delete button is disabled until hidden selections are resolved - "deselect hidden" link removes only the invisible selections, preserving the visible ones so the user can continue bulk actions
vakovalskii
added a commit
that referenced
this pull request
Apr 17, 2026
…lytics tabs Merged PRs: - #182 (@rrr3try): Show Claude Code recap (away_summary) as session title - #181 (@NovakPAai): Block bulk delete for filter-hidden sessions - #180 (@NovakPAai): Detect new sessions in existing dirs + local-agent-mode - #179 (@NovakPAai): Message sort toggle in session drawer + default setting - #86 (@NovakPAai): Sub-tabs in Cost Analytics (Overview/Breakdown/History) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vakovalskii
added a commit
that referenced
this pull request
Apr 17, 2026
…lytics tabs (#183) Merged PRs: - #182 (@rrr3try): Show Claude Code recap (away_summary) as session title - #181 (@NovakPAai): Block bulk delete for filter-hidden sessions - #180 (@NovakPAai): Detect new sessions in existing dirs + local-agent-mode - #179 (@NovakPAai): Message sort toggle in session drawer + default setting - #86 (@NovakPAai): Sub-tabs in Cost Analytics (Overview/Breakdown/History) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user selects sessions in select mode, then applies a search or filter, some selected sessions disappear from view — but remain in
selectedIds. Clicking "Delete Selected" would silently delete those invisible sessions, with no warning.This is a silent data loss bug.
Fix
Three changes:
updateBulkBar()— comparesselectedIdsagainstfilteredSessions. If any selected IDs are not visible, shows an amber warning:⚠ N hidden by filter — deselect hiddenDelete button — disabled (
disabled+ tooltip) while hidden selections exist. User cannot delete until the ambiguity is resolved.clearHiddenSelections()— new function, triggered by the "deselect hidden" link. Removes only the invisible IDs fromselectedIds, preserves the visible ones so the user can continue with bulk actions.Before / After
Test plan