Exclusions don't seem to work properly in scope: raw

[Ravlen]

Another minor bug, but it seems like exclusions don't work as expected for rules using scope: raw. I can add the standard exclusions for all of our rules that don't use scope: raw, but none of the rules that DO use it can't be excluded properly.

See how the first rule gives suggestions, then within the exclusion block it does not. Then the second rule (which uses scope: raw does not exclude the alert:

The weird thing is that if you forget to add the second line (to re-enable the rule), it then excludes the rule from the entire file, including lines BEFORE the exclusion. Non-scope: raw rules work as expected, only excluding everything after the exclusion line:

cc @jdkato

[jdkato]

This is the same issue as #194: any HTML-related scoping / configuration features aren't compatible with scope: raw (this includes HTML comments, BlockIgnores, TokenIgnores, IgnoredClasses, and SkippedScopes).

The weird thing is that if you forget to add the second line (to re-enable the rule), it then excludes the rule from the entire file, including lines BEFORE the exclusion.

It's not clear to me what's happening here since this shouldn't be related to ignore comments (as mentioned above). Is it possible that the comment placement is interfering with the rule's regex?

[Ravlen]

@jdkato Ahh, when it started to work partially (when I added the first line), I thought you might have implemented it and I just missed it in a minor release or something.

It's definitely not being caught by the regex, I think. I changed the regex to be just Internal, and the behavior is the same. Add the exclusion start, and it's turned off for the whole page. Add the exclusion end, and it's as if there is no exclusion at all.

[jdkato]

Could you share the gitlab.InternalLinkExtension rule?

[Ravlen]

@jdkato Whoops, missed the ping. Here you go (from: https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/.vale/gitlab/InternalLinkExtension.yml):

extends: existence
message: 'Link "%s" must use the .md file extension.'
link: https://docs.gitlab.com/ee/development/documentation/styleguide.html#links-to-internal-documentation
level: error
scope: raw
raw:
  - '\[.+\]\((https?:){0}[\w\/\.-]+(\.html).*?\)'

It was written a while back, and we've learned a lot more about Vale since then, it's very possible we're doing something that we shouldn't. Still, I tested it by removing all the regex and just looking for a single word in a scope: raw rules, and saw the same behavior. For example:

extends: existence
message: 'Don't use within.'
level: error
scope: raw
raw:
  - 'within'

• 
• 
• 

[jdkato]

This has been fixed in the sense that ignore comments will now (correctly) not effect scope: raw rules, but the limitations mentioned in #272 (comment) still apply.