Merged
Conversation
Setting the extension when checking file content through command line with cli, it was not possible to check with path based configurations. For example any rule set to check */documentation/en/*.md would not hit any markdown files because only the extension was passed. This adds the "path" parameter to the command line. This allows better integration into IDE plugins that may send the current unsaved file content to vale for a check but then also need to pass a path.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This concerns command line use and the use of the command line for IDE plugins that use the command line to interact with vale.
Setting the file extension when checking file content through command line, it was not possible to lint with path based vale configurations. For example any rule set to check
*/documentation/en/*.mdwould not hit any markdown files because only the extension was passed through the cli.This pull request adds the "path" parameter to the cli. This allows better integration into IDE plugins that may send the current unsaved file content to vale for a check but then also need to pass a path in order for rules to match properly.
The underlying issue has also been discussed to some extent here (Vale Plugin for IntelliJ): https://gitlab.com/pablomxnl/vale-cli-plugin/-/merge_requests/49