Change the default machine type to q35#16
Open
eduffy-redhat wants to merge 1 commit intovalidatedpatterns:mainfrom
Open
Change the default machine type to q35#16eduffy-redhat wants to merge 1 commit intovalidatedpatterns:mainfrom
eduffy-redhat wants to merge 1 commit intovalidatedpatterns:mainfrom
Conversation
Before, we explicitly set the machineType to pc-q35-rhel8.4.0 which is deprecated in 4.21. If we just set the default to 'q35' then Kubevirt will chose the most up to date version it can. If the user needs a specific version they can change the default or they can set it on a specific vm with the 'machineType' field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we explicitly set the machineType to pc-q35-rhel8.4.0 which is deprecated in 4.21. If we just set the default to 'q35' then Kubevirt will chose the most up to date version it can. If the user needs a specific version they can change the default or they can set it on a specific vm with the 'machineType' field.