feat: Externalize 5 charts to validatedpatterns repos#106
Merged
Conversation
Collaborator
|
Hi @minmzzhang I would recommend that we source from the VP Helm Chart repository instead of sourcing in each GitHub repository via an Argo CD as a Git source. @day0hero @mhjacks would the use of the VP Helm Chart repository be the preferred source of content? |
- Reference certmanager, compliance-scanning, keycloak (RHBK), quay-registry, and zero-trust-workload-identity-manager from external Git repos in values-hub.yaml (repoURL + path: . + targetRevision) instead of local charts/ paths. - Remove chart directories: certmanager, compliance-scanning, keycloak, quay-registry, zero-trust-workload-identity-manager. - Keycloak interop tests: drop in-tree tests and modify_keycloak_hostname; keep pod state and default-hostname reachability; add override-based tests for customized and empty hostname via values-hub (modify_keycloak_hostname_via_hub_overrides). External repos and pinned tag versions: - ocp-certmanager-chart: v0.2.0 - ocp-compliance-scanning-chart: v0.0.1 - quay-chart: v0.1.0 (commented out) - rhbk-chart: v0.0.2 - ztwim-chart: v0.1.0 Signed-off-by: Min Zhang <minzhang@redhat.com>
Signed-off-by: Min Zhang <minzhang@redhat.com>
minmzzhang
force-pushed
the
externalize-charts
branch
from
66c6a88 to
80815a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.