ACS runtime custom policies update#116
Merged
minmzzhang merged 3 commits intoApr 1, 2026
Merged
Conversation
added 2 commits
April 1, 2026 21:41
…them. It strips all zero-value booleans from the spec which can lead to OutOfSync status in ArgoCD.
minmzzhang
reviewed
Apr 1, 2026
Collaborator
minmzzhang
left a comment
minmzzhang
left a comment
There was a problem hiding this comment.
lgtm other than the suspicious execute command list, shall we review again that part?
…sed too broadly in many system components or init scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the ACS runtime policies to targeted approach, where in scope there is only our test
qtodoapplication namespace. These custom policies are not global like before.Additionally I found one more issue with ACS normalization SecurityPolicy resources after ArgoCD creates them. I fixed it as well. It's already tested in a fresh cluster.
Ready for review and merge.