Qtodo OIDC refactor#118
Merged
sabre1041 merged 5 commits intovalidatedpatterns:mainfrom Apr 23, 2026
Merged
Conversation
p-rog
reviewed
Apr 8, 2026
p-rog
reviewed
Apr 8, 2026
p-rog
reviewed
Apr 8, 2026
Collaborator
|
LGTM |
p-rog
approved these changes
Apr 9, 2026
Collaborator
|
@mlorenzofr with the integration of #99 , conflicts are now introduced in this PR. Would you be able to review and make the appropriate changes? |
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
mlorenzofr
force-pushed
the
qtodo-oidc-refactor
branch
from
c5bba27 to
39f5b7c
Compare
sabre1041
requested changes
Apr 23, 2026
Collaborator
sabre1041
left a comment
sabre1041
left a comment
There was a problem hiding this comment.
Tested and verified. Works great!
A few comments related to the documentation. Once addressed, we should be good to go
| @@ -0,0 +1,81 @@ | |||
| # Azure Entra ID integration | |||
Collaborator
There was a problem hiding this comment.
There probably needs to be a BYO OIDC guide that talks about the supportability/status within the pattern along with provider specific approaches (such as this document) remaining separate from the top level document
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
sabre1041
approved these changes
Apr 23, 2026
Collaborator
sabre1041
left a comment
sabre1041
left a comment
There was a problem hiding this comment.
LGTM
Its good to see this integration start to take shape. Still a long way to go. However, this is a great start
mlorenzofr
added a commit
to mlorenzofr/layered-zero-trust
that referenced
this pull request
Apr 23, 2026
* Refactor qtodo chart for integration with additional OIDCs Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com> * Add docs/entraid.md Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com> * Add suggestions from 1st revision Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com> * Remove pending components in entraid documentation Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com> * Add fallback warning message to RHBK Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com> --------- Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
mlorenzofr
added a commit
to mlorenzofr/layered-zero-trust
that referenced
this pull request
Apr 27, 2026
* Refactor qtodo chart for integration with additional OIDCs Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com> * Add docs/entraid.md Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com> * Add suggestions from 1st revision Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com> * Remove pending components in entraid documentation Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com> * Add fallback warning message to RHBK Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com> --------- Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes prepare the qtodo application for its future integration with Azure Entra ID.