-
Notifications
You must be signed in to change notification settings - Fork 19
fix/ESO upgrade #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
day0hero
wants to merge
4
commits into
validatedpatterns:main
Choose a base branch
from
day0hero:fix/ESO_upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix/ESO upgrade #123
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,5 @@ | ||
| .PHONY: default | ||
| default: help | ||
| # Generated by patternizer | ||
| # This Makefile includes the common pattern targets from Makefile-common | ||
| # You can add custom targets above or below the include line | ||
|
|
||
| .PHONY: help | ||
| ##@ Pattern tasks | ||
|
|
||
| # No need to add a comment here as help is described in common/ | ||
| help: | ||
| @make -f common/Makefile MAKEFILE_LIST="Makefile common/Makefile" help | ||
|
|
||
| %: | ||
| make -f common/Makefile $* | ||
|
|
||
| .PHONY: install | ||
| install: operator-deploy post-install ## installs the pattern and loads the secrets | ||
| @echo "Installed" | ||
|
|
||
| .PHONY: post-install | ||
| post-install: ## Post-install tasks | ||
| make load-secrets | ||
| make vault-config-jwt | ||
| @echo "Done" | ||
|
|
||
| .PHONY: test | ||
| test: | ||
| @make -f common/Makefile PATTERN_OPTS="-f values-global.yaml -f values-hub.yaml" test | ||
| include Makefile-common | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| MAKEFLAGS += --no-print-directory | ||
| ANSIBLE_STDOUT_CALLBACK ?= rhvp.cluster_utils.readable | ||
| ANSIBLE_RUN ?= ANSIBLE_STDOUT_CALLBACK=$(ANSIBLE_STDOUT_CALLBACK) ansible-playbook $(EXTRA_PLAYBOOK_OPTS) | ||
| DOCS_URL := https://validatedpatterns.io/blog/2025-08-29-new-common-makefile-structure/ | ||
|
|
||
| .PHONY: help | ||
| help: ## Print this help message | ||
| @echo "For a complete guide to these targets and the available overrides, please visit $(DOCS_URL)" | ||
| @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m<target>\033[0m\n"} /^(\s|[a-zA-Z_0-9-])+:.*?##/ { printf " \033[36m%-35s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) | ||
|
|
||
| ##@ Pattern Install Tasks | ||
| .PHONY: show | ||
| show: ## Shows the template that would be applied by the `make install` target | ||
| @$(ANSIBLE_RUN) rhvp.cluster_utils.show | ||
|
|
||
| .PHONY: operator-deploy | ||
| operator-deploy operator-upgrade: ## Installs/updates the pattern on a cluster (DOES NOT load secrets) | ||
| @$(ANSIBLE_RUN) rhvp.cluster_utils.operator_deploy | ||
|
|
||
| .PHONY: install | ||
| install: pattern-install ## Installs the pattern onto a cluster (Loads secrets as well if configured) | ||
|
|
||
| .PHONY: uninstall | ||
| uninstall: ## (EXPERIMENTAL) See https://validatedpatterns.io/blog/2026-02-16-pattern-uninstall/. | ||
| @$(ANSIBLE_RUN) rhvp.cluster_utils.uninstall | ||
|
|
||
| .PHONY: pattern-install | ||
| pattern-install: | ||
| @$(ANSIBLE_RUN) rhvp.cluster_utils.install | ||
|
|
||
| .PHONY: load-secrets | ||
| load-secrets: ## Loads secrets onto the cluster (unless explicitly disabled in values-global.yaml) | ||
| @$(ANSIBLE_RUN) rhvp.cluster_utils.load_secrets | ||
|
|
||
| ##@ Validation Tasks | ||
| .PHONY: validate-prereq | ||
| validate-prereq: ## verify pre-requisites | ||
| @$(ANSIBLE_RUN) rhvp.cluster_utils.validate_prereq | ||
|
|
||
| .PHONY: validate-origin | ||
| validate-origin: ## verify the git origin is available | ||
| @$(ANSIBLE_RUN) rhvp.cluster_utils.validate_origin | ||
|
|
||
| .PHONY: validate-cluster | ||
| validate-cluster: ## Do some cluster validations before installing | ||
| @$(ANSIBLE_RUN) rhvp.cluster_utils.validate_cluster | ||
|
|
||
| .PHONY: validate-schema | ||
| validate-schema: ## validates values files against schema in common/clustergroup | ||
| @$(ANSIBLE_RUN) rhvp.cluster_utils.validate_schema | ||
|
|
||
| .PHONY: argo-healthcheck | ||
| argo-healthcheck: ## Checks if all argo applications are synced | ||
| @$(ANSIBLE_RUN) rhvp.cluster_utils.argo_healthcheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,15 @@ | ||
| [defaults] | ||
| localhost_warning=False | ||
| retry_files_enabled=False | ||
| library=~/.ansible/plugins/modules:./ansible/plugins/modules:./common/ansible/plugins/modules:/usr/share/ansible/plugins/modules | ||
| roles_path=~/.ansible/roles:./ansible/roles:./common/ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles | ||
| filter_plugins=~/.ansible/plugins/filter:./ansible/plugins/filter:./common/ansible/plugins/filter:/usr/share/ansible/plugins/filter | ||
| # Retry files disabled to avoid cluttering CI/CD environments | ||
| interpreter_python=auto_silent | ||
| timeout=30 | ||
| library=~/.ansible/plugins/modules:./ansible/plugins/modules:/usr/share/ansible/plugins/modules | ||
| roles_path=~/.ansible/roles:./ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles | ||
| filter_plugins=~/.ansible/plugins/filter:./ansible/plugins/filter:/usr/share/ansible/plugins/filter | ||
| # use the collections from the util. container, | ||
| # change below if you want to test local collections | ||
| collections_path=/usr/share/ansible/collections | ||
|
|
||
| [inventory] | ||
| inventory_unparsed_warning=False |
2 changes: 1 addition & 1 deletion
2
charts/acm-managed-clusters/templates/acm-external-secrets.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
charts/acs-central/templates/central-htpasswd-external-secret.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
charts/acs-central/templates/keycloak-client-secret-external-secret.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
charts/rhtpa-operator/templates/postgresql-external-secret.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the
post-install(a target not present in theMakefile-common), in addition toload-secrets,vault-config-jwtwas also called. I don't believe this is part of the common VP workflow, but we need it