Skip to content

Fix cache #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strug merged 1 commit into from
Jan 30, 2026
Merged

Fix cache #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/dev/vality/fraudbusters/resource/payment/handler/InspectorHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import dev.vality.fraudbusters.fraud.model.PaymentModel;
import dev.vality.fraudbusters.stream.TemplateVisitor;
import dev.vality.fraudbusters.util.PaymentModelFactory;
import dev.vality.fraudbusters.util.UserCacheKeyUtil;
import dev.vality.fraudo.constant.ResultStatus;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
Expand Down Expand Up @@ -65,5 +66,8 @@ private static boolean isDeclineResult(CheckedResultModel result) {
|| ResultStatus.DECLINE_AND_NOTIFY.equals(result.getResultModel().getResultStatus()));
}

public String buildInspectUserCacheKey(InspectUserContext context) {
return UserCacheKeyUtil.buildInspectUserCacheKey(context);
}

}
16 changes: 8 additions & 8 deletions src/main/java/dev/vality/fraudbusters/util/UserCacheKeyUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package dev.vality.fraudbusters.util;

import dev.vality.damsel.proxy_inspector.InspectUserContext;
import dev.vality.damsel.proxy_inspector.ShopContext;
import dev.vality.damsel.fraudbusters.InspectUserContext;
import dev.vality.damsel.fraudbusters.ShopContext;
import dev.vality.fraudbusters.constant.ClickhouseUtilsValue;
import org.springframework.util.StringUtils;

Expand All @@ -20,9 +20,9 @@ public static String buildInspectUserCacheKey(InspectUserContext context) {
email = context.getUserInfo().isSetEmail() && StringUtils.hasLength(context.getUserInfo().getEmail())
? context.getUserInfo().getEmail().toLowerCase()
: ClickhouseUtilsValue.UNKNOWN;
phone = context.getUserInfo().isSetPhoneNumber()
&& StringUtils.hasLength(context.getUserInfo().getPhoneNumber())
? context.getUserInfo().getPhoneNumber()
phone = context.getUserInfo().getPhone() != null
&& StringUtils.hasLength(context.getUserInfo().getPhone())
? context.getUserInfo().getPhone()
: ClickhouseUtilsValue.UNKNOWN;
}
if (context.getShopList() == null || context.getShopList().isEmpty()) {
Expand All @@ -36,11 +36,11 @@ public static String buildInspectUserCacheKey(InspectUserContext context) {
}

private static String buildShopKey(ShopContext shopContext) {
if (shopContext == null || shopContext.getParty() == null || shopContext.getShop() == null) {
if (shopContext == null || shopContext.getPartyId() == null || shopContext.getShopId() == null) {
return ClickhouseUtilsValue.UNKNOWN;
}
String partyId = shopContext.getParty().getPartyRef().getId();
String shopId = shopContext.getShop().getShopRef().getId();
String partyId = shopContext.getPartyId();
String shopId = shopContext.getShopId();
return partyId + ":" + shopId;
}
}
Expand Down
Loading