add exrate listener #72
Conversation
bump service parent pom
src/main/resources/application.yml
Outdated
| exrate: | ||
| id: etl-exchange-rate | ||
| enabled: false | ||
| consumer.group-id: "newway-exrate" |
There was a problem hiding this comment.
тут они не будут конфликтовать с newway?
| "kafka.topics.limit-config.id", | ||
| "kafka.topics.limit-config.id", |
| CREATE TABLE dw.exrate | ||
| ( | ||
| id BIGSERIAL NOT NULL, | ||
| event_id uuid UNIQUE NOT NULL, | ||
| event_created_at TIMESTAMP WITHOUT TIME ZONE NOT NULL, | ||
| source_currency_symbolic_code CHARACTER VARYING NOT NULL, | ||
| source_currency_exponent SMALLINT NOT NULL, | ||
| destination_currency_symbolic_code CHARACTER VARYING NOT NULL, | ||
| destination_currency_exponent SMALLINT NOT NULL, | ||
| rational_p BIGINT NOT NULL, | ||
| rational_q BIGINT NOT NULL, | ||
| rate_timestamp TIMESTAMP WITHOUT TIME ZONE NOT NULL | ||
| ); |
There was a problem hiding this comment.
не должно быть ex_rate? Это же от exchange_rate?
Сущность создается Exrate, хотя имхо должна быть ExRate.
mr-impossibru
left a comment
mr-impossibru
left a comment
There was a problem hiding this comment.
Не увидел тест на новое Dao, но не критично
|
|
||
| public interface ExchangeRateHandler { | ||
|
|
||
| void handle(CurrencyEvent currencyEvent); |
There was a problem hiding this comment.
Не хочешь сделать тут сохранение пачки?
Обычно по возможности сразу набор сущностей в БД сохраняем.
| .map(exrate -> getDslContext().newRecord(EX_RATE, exrate)) | ||
| .map(record -> (Query) getDslContext().insertInto(EX_RATE).set(record) | ||
| .onConflict(EX_RATE.EVENT_ID) | ||
| .doNothing()).collect(Collectors.toList()); |
There was a problem hiding this comment.
форматирование
.doNothing())
.collect(Collectors.toList());
There was a problem hiding this comment.
Надо взять за правило, если линтер не тригерится, значит не считается) Но я поправлю
| CurrencyExchangeRate exchangeRate = currencyEvent.getPayload().getExchangeRate(); | ||
| ExRate exrate = new ExRate(); | ||
| exrate.setEventId(UUID.fromString(currencyEvent.getEventId())); | ||
| exrate.setEventCreatedAt(TypeUtil.stringToLocalDateTime(currencyEvent.getEventCreatedAt())); | ||
| exrate.setSourceCurrencySymbolicCode(exchangeRate.getSourceCurrency().getSymbolicCode()); | ||
| exrate.setSourceCurrencyExponent(exchangeRate.getSourceCurrency().getExponent()); | ||
| exrate.setDestinationCurrencySymbolicCode(exchangeRate.getDestinationCurrency().getSymbolicCode()); | ||
| exrate.setDestinationCurrencyExponent(exchangeRate.getDestinationCurrency().getExponent()); | ||
| exrate.setRationalP(exchangeRate.getExchangeRate().getP()); | ||
| exrate.setRationalQ(exchangeRate.getExchangeRate().getQ()); | ||
| exrate.setRateTimestamp(TypeUtil.stringToLocalDateTime(exchangeRate.timestamp)); | ||
| return exrate; |
There was a problem hiding this comment.
Опционально, не хочешь вынести в конвертер или отдельный метод внутри handler'а?
There was a problem hiding this comment.
По-хорошему, тут везде надо рефакторить и заводить конвертеры. Ну короч хз, читабельнее щас от этого не станет. Если очень хочешь, тогда сделаю конечно.
There was a problem hiding this comment.
Не, у меня были сомнения и я решил тебе о них сказать :)
вдруг бы тоже сомнения породил xD
add exchange rate listener
bump service parent pom