Update submodules#27
Merged
Merged
Conversation
0xArdi
approved these changes
Feb 24, 2023
dagacha
approved these changes
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOC SUBMODULE UPDATE PR
Please, each PO approve this PR after confirming that for the submodule linked to their repos:
The submodule update is pointing to the intended commit, which should be the latest tag/release.
To the best of your knowledge, the public-facing tutorial in the submodule (
<submodule_folder>/docs/index.md) is up to date. In particular, you agree with the instructions in the section "Demo".You have replicated the instructions exactly as described in the public-facing tutorial (with the exact options, hash values, command line parameters, private keys, etc. described there), in a clean virtual environment, and it has worked. Also:
a. an external user is able to replicate the demo with these instructions, or
b. if this is not 100% possible, (e.g., due to requiring private API keys, registered addresses, etc) this limitation is clearly informed to the user in the tutorial.