Add WithLimit methods for uncompression#2147
Merged
Merged
Conversation
The current uncompress methods don't enforce a memory limit and are susceptible to things like zip bombs. This pull introduces new methods so retain backwards compatibility. The old methods might be deprecated in the future.
There was a problem hiding this comment.
Pull request overview
This PR adds new WithLimit APIs for request/response body decompression (gzip/deflate/brotli/zstd) and multipart form parsing, so callers can enforce an upper bound on uncompressed body size to mitigate memory-exhaustion attacks (e.g., zip bombs) while keeping existing methods for backwards compatibility.
Changes:
- Add
Body*WithLimit/BodyUncompressedWithLimitmethods and route existing helpers through the new limit-aware paths. - Add
Request.MultipartFormWithLimit/RequestCtx.MultipartFormWithLimitand clarifyServer.FormValueFuncdocs for multipart parsing limits. - Add shared
copyZeroAllocWithLimithelper plus tests covering size-limit enforcement across encodings and multipart gzip bodies.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
http.go |
Introduces limit-aware decompression APIs, multipart parsing with limits, and copyZeroAllocWithLimit. |
compress.go |
Refactors gunzip/inflate writers to use internal limit-aware helpers. |
brotli.go |
Refactors brotli decompression writer to use internal limit-aware helper. |
zstd.go |
Refactors zstd decompression writer to use internal limit-aware helper. |
server.go |
Updates docs and exposes RequestCtx.MultipartFormWithLimit to guide safe multipart parsing. |
http_test.go |
Adds tests ensuring ErrBodyTooLarge is returned when uncompressed size exceeds the limit. |
README.md |
Documents MultipartFormWithLimit guidance for untrusted multipart input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current uncompress methods don't enforce a memory limit and are susceptible to things like zip bombs. This pull introduces new methods so retain backwards compatibility. The old methods might be deprecated in the future.