client: add aggregate connection count metrics#2201
Merged
erikdubbelboer merged 2 commits intoMay 17, 2026
Conversation
erikdubbelboer
requested changes
May 16, 2026
Comment on lines
+123
to
+134
| func TestClientConnectionCountsEmpty(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| var c Client | ||
| if n := c.ConnsCount(); n != 0 { | ||
| t.Fatalf("unexpected connection count %d. Expecting %d", n, 0) | ||
| } | ||
| if n := c.IdleConnsCount(); n != 0 { | ||
| t.Fatalf("unexpected idle connection count %d. Expecting %d", n, 0) | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
This is already tested in the above test as well, please remove this test.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Client.ConnsCount() and Client.IdleConnsCount(), aggregating across all managed HostClients (both http and https maps). Also adds HostClient.IdleConnsCount() since there was no public accessor for per-host idle count.
Closes #2200