Add back the Device Manager from x/ref/services/device/#78
Merged
razvanm merged 5 commits intovanadium:masterfrom Jan 7, 2019
Merged
Add back the Device Manager from x/ref/services/device/#78razvanm merged 5 commits intovanadium:masterfrom
razvanm merged 5 commits intovanadium:masterfrom
Conversation
Contributor
|
Ok, so I refactored how factories/profiles work and to get these tests to pass you need to make a slight change to the tests. See, for example, ./x/ref/cmd/principal/principal_v23_test.go: func init() { |
razvanm
force-pushed
the
device
branch
2 times, most recently
from
4fcf69c to
03f11ad
Compare
cosnicolaou
approved these changes
Jan 6, 2019
Contributor
cosnicolaou
left a comment
cosnicolaou
left a comment
There was a problem hiding this comment.
ok, let's add this back in and then figure out how to simplify it.
I did not include the x/services/device/dmrun because it has some depencies on jiri that I need to look into. This also doesn't include any of the other daemons that the device managed
This script works fine. I did not initially included because I was not sure it's relevant.
Both of these are necessary to for starting an application using deviced/device.
Collaborator
Author
|
I managed to use this to run a mounttabled and fortuned on my machine. I'll start a doc to track my experience. Quick note: I also brought back the wiki page Device Management that talks about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not include the x/services/device/dmrun because it has some
depencies on jiri that I need to look into. This also doesn't include
any of the other daemons that the device manager is using.