Fix iter_rows_keyset infinite loop on NULL by column (#1)#2
Merged
Conversation
When the keyset cursor's `by` column was NULL at a full-page boundary, `WHERE by > NULL` evaluated false, so the next page re-fetched the same rows forever -- silent hang, no error. Raise ValueError before yielding the offending page, so callers don't get partial results from an invalid stream. Only triggers when the page is full (a short final page ending in NULL is harmless -- the cursor terminates anyway). Fixes #1.
varjoranta
force-pushed
the
fix/iter-keyset-null-by
branch
from
4cf158e to
0c3985b
Compare
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db.iter_rows_keysetlooped forever when thebycolumn had NULL at a full-page boundary, becauseWHERE by > NULLis always false and the next page refetched the same rows.ValueErrorbefore yielding the offending page, so callers don't get partial results from an invalid stream.len(rows) == batch_size); a short final page ending in NULL is harmless because the cursor terminates anyway.Fixes #1.
Test plan
uv run pytest: 487 passed, 1 skipped (was 484/1).uv run ruff check: clean.Out of scope
Tied non-NULL
byvalues silently drop rows from the same WHERE-cursor family. Different fix shape (compound(by, pk)cursor with dialect-specific NULL ordering); will track separately.