Skip to content

Conversation

@tony
Copy link
Member

@tony tony commented Jul 30, 2022

Strict mypy typings.

This is lots of changes.

@tony tony force-pushed the strict-mypy branch 5 times, most recently from bb730c2 to a415bd6 Compare July 31, 2022 15:46
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #390 (3f67566) into master (80db558) will decrease coverage by 0.80%.
The diff coverage is 70.61%.

❗ Current head 3f67566 differs from pull request most recent head 55e6190. Consider uploading reports for the commit 55e6190 to get more accurate results

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   73.64%   72.84%   -0.81%     
==========================================
  Files          26       26              
  Lines        2178     2250      +72     
==========================================
+ Hits         1604     1639      +35     
- Misses        574      611      +37     
Impacted Files Coverage Δ
tests/parse/test_git.py 100.00% <ø> (ø)
tests/parse/test_hg.py 100.00% <ø> (ø)
tests/parse/test_svn.py 100.00% <ø> (ø)
tests/projects/test_conftest.py 100.00% <ø> (ø)
libvcs/projects/svn.py 50.37% <30.18%> (-14.90%) ⬇️
libvcs/cmd/svn.py 52.23% <51.51%> (ø)
docs/conf.py 62.10% <71.42%> (-0.27%) ⬇️
libvcs/parse/base.py 86.11% <83.33%> (-2.13%) ⬇️
libvcs/projects/git.py 74.63% <86.66%> (-1.18%) ⬇️
libvcs/projects/base.py 92.53% <90.90%> (-1.31%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tony tony linked an issue Jul 31, 2022 that may be closed by this pull request
@tony tony added this to the v0.14 milestone Jul 31, 2022
@tony tony self-assigned this Jul 31, 2022
@tony tony force-pushed the strict-mypy branch 2 times, most recently from 3f67566 to f6a72ea Compare July 31, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

mypy: stricter++

2 participants