Update imports to wstools in some more places.

[gavanderhoorn]

I haven't touched the documentation, which refers to things in rosinstall that seem to be in wstool now in some places.

[tfoote]

Thanks for the updates. I'll get it released soon.

[gavanderhoorn]

np.

AFAICT all tests pass, but they did so even with the incorrect import statements. Is that supposed to happen?

[tfoote]

The unit tests cover the source quite well, but all these patches were actually in the minimal wrapper scripts which can only be tested by actually running the scripts. So to get coverage of the scripts we need to have a test which subprocess calls the scripts. I'm looking at how to make sure to get all the paths right and make that robust.

[tkruse]

Thanks for cleaning up after me. The tests cover all of
rosinstall/rosws/wstool classes, which is the bulk of rosinstall, and the
part that buildservers and ROS tutorials depend upon.
The other scripts were never important enough to be tested, or even
documented.

The standard way of writing unit tests is to make the other tests proper
modules as well, and just invoke a main function in the executable script.
I understand it would be nice to have them python3 ready as well, but
really those scripts could also just be deleted in the course of reducing
overall maintenance effort. They are not essential.

On Thu, Dec 19, 2013 at 9:41 AM, G.A. vd. Hoorn notifications@github.comwrote:

np.

AFAICT all tests pass, but they did so even with the incorrect import
statements. Is that supposed to happen?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/91#issuecomment-30912978
.