Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

Add option --versioned to scrape verb#135

Closed
rhaschke wants to merge 4 commits into
vcstools:masterfrom
rhaschke:master
Closed

Add option --versioned to scrape verb#135
rhaschke wants to merge 4 commits into
vcstools:masterfrom
rhaschke:master

Conversation

@rhaschke
Copy link
Copy Markdown

@rhaschke rhaschke commented May 9, 2019

This implements #124.

jacobperron and others added 2 commits August 30, 2018 11:23
... to allow storing the current version label of unmanaged repos
@rhaschke
Copy link
Copy Markdown
Author

rhaschke commented May 9, 2019

Note that this also includes #106 as I was in need of this feature as well.

description=__MULTIPRO_CMD_DICT__["scrape"],
epilog="See: http://www.ros.org/wiki/rosinstall for details\n")
parser.add_option("-y", "--confirm", dest="confirm", default='',
parser.add_option("-y", "--confirm", dest="confirm", default=False,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the bash completions if adding command-line options: https://github.com/vcstools/wstool/blob/master/completion/wstool-completion.bash

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scrape wasn't in the bash completion list before, but I added it with all its options now 😉

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@rhaschke
Copy link
Copy Markdown
Author

rhaschke commented Jun 20, 2019

Hi @wjwwood,
scanning my open PRs, I just noted that this one is not yet merged. I also noted the Travis failure.
One failure was indeed due to a change I made: As I added a version column to the status output table, I had to adapt the corresponding unittest as well. With this fix, locally the unittest passes for me.
The other Travis failures seem to be unrelated to this PR. The master branch is failing already as shown in this dummy PR (#136).

@rhaschke
Copy link
Copy Markdown
Author

I fixed the unrelated Travis issues in #137.

@romainreignier
Copy link
Copy Markdown

romainreignier commented Oct 29, 2019

This PR seems very interesting. Any idea why it was not merged nor commented?

@tkruse
Copy link
Copy Markdown
Contributor

tkruse commented Dec 8, 2019

@romainreignier : It seems reasonable to assume it#s the same reason as for all other open PRs.

@romainreignier
Copy link
Copy Markdown

@tkruse If I understand well, this tool is kind of unmaintained, right?

@tkruse
Copy link
Copy Markdown
Contributor

tkruse commented Dec 14, 2019

@romainreignier : yes, kind of

@Levi-Armstrong
Copy link
Copy Markdown

Is there any plans on merging this? It is a very useful feature when developing with a team and you have multiple repositories you are modifying that depend on each other, one can use this to create a new rosinstall file with the exact state of the workspace and provide it to another developer to quickly get there machine to the exact state you are developing from for testing.

@Levi-Armstrong
Copy link
Copy Markdown

Ping!

@dirk-thomas
Copy link
Copy Markdown
Contributor

Closing since the repository is about to be archived: see #154.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants