feat: Add is_log and is_metric conditions#1950
Conversation
is_log and is_metric conditionsis_log and is_metric conditions
binarylogic
left a comment
There was a problem hiding this comment.
This makes sense! I like it. Would check_fields apply to metrics tags or would we add a new check_tags type?
|
Yeah |
|
Ah, yeah our terminology isn't consistent here. Ex: |
|
For transforms I'd say it helps to be more explicit. Right now conditions are kind of hidden in that you can live a successful and enriched life without knowing there's anything other than As we expand it might be worth eventually making an explicit |
Signed-off-by: Ashley Jeffs <ash@jeffail.uk>
dbe338d to
dbb6d35
Compare
This adds two new conditions
is_logandis_metric, which are fairly self explanatory. They will allow writers of unit tests to check the actual type of an event coming out of certain transforms.It will also allow users to create swimlanes that separate logs from metrics to different outputs. However, for swimlanes this currently isn't useful at all as it is forced to deal only in logs until #421 is solved.