Skip to content

Conversation

@pront
Copy link
Member

@pront pront commented May 23, 2024

No description provided.

@github-actions github-actions bot added the domain: transforms Anything related to Vector's transform components label May 23, 2024
@pront
Copy link
Member Author

pront commented May 23, 2024

/ci-run-component-features

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 23, 2024
@pront pront force-pushed the pront/reduce-feats-fix branch from 9718604 to 161d201 Compare May 23, 2024 14:29
@pront pront force-pushed the pront/reduce-feats-fix branch from 161d201 to b0a58d6 Compare May 23, 2024 14:33
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented May 23, 2024

Datadog Report

Branch report: pront/reduce-feats-fix
Commit report: a74522a
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the component features check passes 👍

@pront pront force-pushed the pront/reduce-feats-fix branch from 0a37485 to 8d1a3b4 Compare May 23, 2024 15:40
@pront pront marked this pull request as ready for review May 23, 2024 15:41
@pront pront requested a review from a team as a code owner May 23, 2024 15:41
@pront pront force-pushed the pront/reduce-feats-fix branch from 8d1a3b4 to 9b333d7 Compare May 23, 2024 16:46
@pront
Copy link
Member Author

pront commented May 23, 2024

@pront pront added this pull request to the merge queue May 23, 2024
@github-actions
Copy link

Regression Detector Results

Run ID: b4bf2858-c46d-4026-8bf2-eb3a91e32616
Baseline: 8b4a3ba
Comparison: 14d8f31
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
datadog_agent_remap_blackhole ingress throughput +1.04 [+0.95, +1.12]
otlp_grpc_to_blackhole ingress throughput +0.82 [+0.72, +0.91]
splunk_hec_route_s3 ingress throughput +0.66 [+0.20, +1.11]
http_to_http_acks ingress throughput +0.61 [-0.75, +1.97]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.58 [+0.50, +0.65]
syslog_regex_logs2metric_ddmetrics ingress throughput +0.48 [+0.33, +0.63]
fluent_elasticsearch ingress throughput +0.33 [-0.15, +0.81]
http_to_http_noack ingress throughput +0.11 [+0.02, +0.20]
datadog_agent_remap_datadog_logs ingress throughput +0.09 [-0.02, +0.19]
http_to_s3 ingress throughput +0.02 [-0.26, +0.30]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.15]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.15, +0.14]
http_to_http_json ingress throughput -0.00 [-0.07, +0.07]
datadog_agent_remap_blackhole_acks ingress throughput -0.03 [-0.11, +0.06]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.15, +0.08]
otlp_http_to_blackhole ingress throughput -0.06 [-0.18, +0.07]
enterprise_http_to_http ingress throughput -0.08 [-0.15, -0.01]
syslog_splunk_hec_logs ingress throughput -0.10 [-0.17, -0.02]
syslog_log2metric_humio_metrics ingress throughput -0.13 [-0.27, +0.00]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.19 [-0.33, -0.05]
syslog_loki ingress throughput -0.36 [-0.41, -0.30]
http_elasticsearch ingress throughput -0.44 [-0.51, -0.37]
socket_to_socket_blackhole ingress throughput -0.65 [-0.73, -0.58]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.94 [-1.06, -0.82]
syslog_humio_logs ingress throughput -1.22 [-1.33, -1.11]
file_to_blackhole egress throughput -1.23 [-3.60, +1.14]
http_text_to_http_json ingress throughput -1.82 [-1.94, -1.69]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 14d8f31 May 23, 2024
@pront pront deleted the pront/reduce-feats-fix branch May 23, 2024 19:02
paomian pushed a commit to paomian/vector that referenced this pull request Jun 12, 2024
* fix(reduce): correct feature gate

* one more tweak
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
* fix(reduce): correct feature gate

* one more tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: transforms Anything related to Vector's transform components no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants