Skip to content

Conversation

@cahartma
Copy link
Contributor

@cahartma cahartma commented Apr 15, 2025

Summary

Resolves issue #22859 by increasing the max event size for cloudwatch log events to ~ 1MB. This matches the new limit updated by AWS.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Added one unit test but so far no functional tests have been run.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

@cahartma cahartma requested a review from a team as a code owner April 15, 2025 17:51
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Apr 15, 2025
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cahartma

@pront pront enabled auto-merge April 15, 2025 18:57
@pront pront changed the title fix(aws_cloudwatch_logs sink) #22831: increase cloudwatch logs max event size to match new aws limit of 1MB fix(aws_cloudwatch_logs sink): increase cloudwatch logs max event size to match new aws limit of 1MB Apr 15, 2025
@pront pront added this pull request to the merge queue Apr 15, 2025
Merged via the queue into vectordotdev:master with commit 3e13278 Apr 15, 2025
56 of 58 checks passed
pront pushed a commit to gllb/vector that referenced this pull request Apr 22, 2025
…e to match new aws limit of 1MB (vectordotdev#22886)

Update cloudwatch logs max event size to match new aws limit of 1MB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: sinks Anything related to the Vector's sinks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase AWS Cloudwatch Logs record limit to 1MB

2 participants