Skip to content

Conversation

@pront
Copy link
Member

@pront pront commented Jun 16, 2025

Summary

Readers might find the sink terminology confusing.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

@pront pront requested a review from thomasqueirozb June 16, 2025 17:54
@pront pront requested a review from a team as a code owner June 16, 2025 17:54
Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should at least have the word sink somewhere. Source/Sink is a common pattern in CS in general

@pront pront enabled auto-merge June 16, 2025 17:59
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 16, 2025
@pront pront added this pull request to the merge queue Jun 16, 2025
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: pront/fix-wording-mem-highlight
Commit report: 656fd95
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.26s Total Time

auto-merge was automatically disabled June 16, 2025 18:22

Pull Request is not mergeable

Merged via the queue into master with commit 3ff55b8 Jun 16, 2025
71 of 73 checks passed
@pront pront deleted the pront/fix-wording-mem-highlight branch June 16, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants