-
Notifications
You must be signed in to change notification settings - Fork 2k
chore(core): use latest VRL and update function signature #23221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| .to_string()) | ||
| } | ||
| let Some(paths) = path.to_alternative_components(MAX_METRIC_PATH_DEPTH) else { | ||
| return Ok(None); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before it'd return vec![] on the effective None case and therefore the for loop would never run and would eventually return Ok(None);. This just makes it more explicit + the comment was very misleading
| | ["tags", _] | ||
| | ["namespace"] | ||
| | ["timestamp"] | ||
| | ["interval_ms"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was missing, feature was working without this so not sure how critical it is
Datadog ReportBranch report: ✅ 0 Failed, 10 Passed, 0 Skipped, 25.26s Total Time |
pront
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat change, thanks!
|
Did you have a chance to manually verify by running a config (similar to what you did for the |
Yes, behavior seems to be the same as in |
Summary
Update to_alternative_components function signature from VRL and add
interval_msto mutable code path amongst other refactors that are now possible.Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)./scripts/check_changelog_fragments.shgit merge origin masterandgit push.Cargo.lock), pleaserun
cargo vdev build licensesto regenerate the license inventory and commit the changes (if any). More details here.References