Skip to content

chore(sinks): remove downcast and trait in sink retry code #23543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomasqueirozb merged 3 commits into from
Aug 7, 2025
Merged

chore(sinks): remove downcast and trait in sink retry code #23543

thomasqueirozb merged 3 commits into from
Aug 7, 2025

Conversation

@thomasqueirozb
Copy link
Contributor

@thomasqueirozb thomasqueirozb commented Aug 6, 2025 •
edited
Loading

Summary

Remove downcast and trait in sink retry code. Made RetryAction generic over Request and added type Request in the RetryLogic trait.

Vector configuration

NA

How did you test this PR?

make check-clippy

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

@thomasqueirozb thomasqueirozb requested a review from a team as a code owner August 6, 2025 20:24
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Aug 6, 2025
@thomasqueirozb thomasqueirozb marked this pull request as draft August 6, 2025 20:24
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Aug 6, 2025 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d10c28a | Docs | Was this helpful? Give us feedback!

@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 7, 2025
@thomasqueirozb thomasqueirozb force-pushed the sinks-retries-remove-downcast-and-trait branch from ebb2858 to b5c0abc Compare August 7, 2025 15:35
@thomasqueirozb thomasqueirozb marked this pull request as ready for review August 7, 2025 15:36
@thomasqueirozb thomasqueirozb added the sink: elasticsearch Anything `elasticsearch` sink related label Aug 7, 2025
pront
pront reviewed Aug 7, 2025
View reviewed changes
pront
pront approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring

@thomasqueirozb thomasqueirozb added this pull request to the merge queue Aug 7, 2025
thomasqueirozb
thomasqueirozb commented Aug 7, 2025
View reviewed changes
@thomasqueirozb thomasqueirozb removed this pull request from the merge queue due to a manual request Aug 7, 2025
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Aug 7, 2025
Merged via the queue into master with commit 0b3c886 Aug 7, 2025
86 checks passed
@thomasqueirozb thomasqueirozb deleted the sinks-retries-remove-downcast-and-trait branch August 7, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pront pront pront approved these changes

Assignees

No one assigned

Labels

domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog sink: elasticsearch Anything `elasticsearch` sink related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomasqueirozb @pront