-
Notifications
You must be signed in to change notification settings - Fork 2k
revert(internal_logs source): disable internal_log_rate_limit by default
#23566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dffcb5a.
internal_log_rate_limit by default (#22899)"internal_log_rate_limit by default (#22899)"
internal_log_rate_limit by default (#22899)"internal_log_rate_limit by default
internal_log_rate_limit by defaultinternal_log_rate_limit by default
002d552 to
405b6c2
Compare
910e745 to
9b3eca6
Compare
thomasqueirozb
approved these changes
Aug 11, 2025
auto-merge was automatically disabled
August 11, 2025 15:32
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain: sinks
Anything related to the Vector's sinks
domain: sources
Anything related to the Vector's sources
domain: topology
Anything related to Vector's topology code
domain: transforms
Anything related to Vector's transform components
no-changelog
Changes in this PR do not need user-facing explanations in the release changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit dffcb5a.
Unfortunately, the existing implementation of tracing flood protection is buggy and although that PR did a great job, it exposed those issues. We want to revert that regression before the next release and properly address the bugs in the tracing lib.
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Related: #22899
Related: #22410
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)git merge origin masterandgit push.Cargo.lock), pleaserun
cargo vdev build licensesto regenerate the license inventory and commit the changes (if any). More details here.