Skip to content

Conversation

@pront
Copy link
Member

@pront pront commented Aug 8, 2025

Summary

This reverts commit dffcb5a.
Unfortunately, the existing implementation of tracing flood protection is buggy and although that PR did a great job, it exposed those issues. We want to revert that regression before the next release and properly address the bugs in the tracing lib.

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Related: #22899
Related: #22410

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@github-actions github-actions bot added domain: sources Anything related to the Vector's sources domain: transforms Anything related to Vector's transform components domain: sinks Anything related to the Vector's sinks labels Aug 8, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 8, 2025
@pront pront changed the title Revert "feat(dev): Enable internal_log_rate_limit by default (#22899)" revert(dev): "feat(dev): Enable internal_log_rate_limit by default (#22899)" Aug 8, 2025
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Aug 8, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9b3eca6 | Docs | Was this helpful? Give us feedback!

@github-actions github-actions bot added the domain: topology Anything related to Vector's topology code label Aug 8, 2025
@pront pront marked this pull request as ready for review August 8, 2025 20:10
@pront pront requested a review from a team as a code owner August 8, 2025 20:10
@pront pront changed the title revert(dev): "feat(dev): Enable internal_log_rate_limit by default (#22899)" revert(dev): internal_log_rate_limit default value Aug 8, 2025
@thomasqueirozb thomasqueirozb changed the title revert(dev): internal_log_rate_limit default value revert(dev): disable internal_log_rate_limit by default Aug 8, 2025
@pront pront changed the title revert(dev): disable internal_log_rate_limit by default revert(internal_logs source): disable internal_log_rate_limit by default Aug 11, 2025
@pront pront enabled auto-merge August 11, 2025 13:31
@thomasqueirozb thomasqueirozb force-pushed the pront-revert-log-rate-limit-default branch from 002d552 to 405b6c2 Compare August 11, 2025 13:34
@thomasqueirozb thomasqueirozb force-pushed the pront-revert-log-rate-limit-default branch from 910e745 to 9b3eca6 Compare August 11, 2025 13:54
@pront pront added this pull request to the merge queue Aug 11, 2025
auto-merge was automatically disabled August 11, 2025 15:32

Pull Request is not mergeable

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2025
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Aug 11, 2025
Merged via the queue into master with commit f49c6cb Aug 11, 2025
100 checks passed
@thomasqueirozb thomasqueirozb deleted the pront-revert-log-rate-limit-default branch August 11, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources domain: topology Anything related to Vector's topology code domain: transforms Anything related to Vector's transform components no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants