-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(codecs): add 'use_json_names' options to protobuf codecs #24002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rtrieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my feedback is primarily the following:
- update "will look" to "looks" (present tense)
- change "e.g." to "for example" (avoid Latin abbreviations)
can you apply these changes throughout the PR? the first rule is to adhere to our style guide, and the second rule is for translation purposes.
thanks!
website/cue/reference/components/sinks/generated/aws_cloudwatch_logs.cue
Outdated
Show resolved
Hide resolved
website/cue/reference/components/sinks/generated/aws_kinesis_firehose.cue
Outdated
Show resolved
Hide resolved
website/cue/reference/components/sinks/generated/aws_kinesis_firehose.cue
Outdated
Show resolved
Hide resolved
website/cue/reference/components/sinks/generated/aws_kinesis_streams.cue
Outdated
Show resolved
Hide resolved
website/cue/reference/components/sinks/generated/aws_kinesis_streams.cue
Outdated
Show resolved
Hide resolved
Updated rustdocs and regenerated the CUE files |
…dotdev#24002) * feat(codecs): add 'use_json_names' options to protobuf codecs * changelog * update docs * docs updates * fix docs * add job description field and enhance test * clippy fixes * docs feedback
Summary
use_json_namesoption to protobuf serializer and deserializer to support JSON field naming (camelCase vs snake_case)Vector configuration
How did you test this PR?
New test and manually tested with the following config:
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
closes: #23971
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.