Skip to content

Conversation

@pront
Copy link
Member

@pront pront commented Oct 22, 2025

Summary

  • Remove internal_log_rate_limit = true
  • Add internal_log_rate_limit = false

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

closes: #22410

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@github-actions github-actions bot added domain: topology Anything related to Vector's topology code domain: sources Anything related to the Vector's sources domain: transforms Anything related to Vector's transform components domain: sinks Anything related to the Vector's sinks domain: core Anything related to core crates i.e. vector-core, core-common, etc labels Oct 22, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 22, 2025
@pront pront marked this pull request as ready for review October 22, 2025 18:40
@pront pront requested a review from a team as a code owner October 22, 2025 18:40
Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments are minor improvements that shouldn't change behavior at all. They can probably be batched into one single commit.

We should take a closer look at the ones where I mentioned that we should set internal_log_rate_limit = false

Co-authored-by: Thomas <thomas.schneider@datadoghq.com>
@pront
Copy link
Member Author

pront commented Oct 22, 2025

Resolving unrelated comments. Each on of those can be tackled in an individual PR.

pront

This comment was marked as off-topic.

@pront pront requested a review from thomasqueirozb October 22, 2025 20:47
Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I missed only one the first time around. All the rest looks good 👍

@thomasqueirozb thomasqueirozb added this pull request to the merge queue Oct 23, 2025
Merged via the queue into master with commit c7889db Oct 23, 2025
47 checks passed
@thomasqueirozb thomasqueirozb deleted the pront-trace-limiting-followup branch October 23, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources domain: topology Anything related to Vector's topology code domain: transforms Anything related to Vector's transform components no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internal_log_rate_limit should be ON by default

3 participants