-
Notifications
You must be signed in to change notification settings - Fork 2k
chore(internal_logs source): update internal_log_rate_limit tags #24050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thomasqueirozb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the comments are minor improvements that shouldn't change behavior at all. They can probably be batched into one single commit.
We should take a closer look at the ones where I mentioned that we should set internal_log_rate_limit = false
Co-authored-by: Thomas <thomas.schneider@datadoghq.com>
|
Resolving unrelated comments. Each on of those can be tackled in an individual PR. |
thomasqueirozb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think I missed only one the first time around. All the rest looks good 👍
Summary
internal_log_rate_limit = trueinternal_log_rate_limit = falseVector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
closes: #22410
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.