Skip to content

fix(blackhole sink): disable rate limiting for periodic stats messages #24190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pront merged 2 commits into from
Nov 7, 2025
Merged

fix(blackhole sink): disable rate limiting for periodic stats messages #24190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
710aae0
fix(blackhole sink): disable rate limiting for periodic stats messages
pront Nov 7, 2025
1377b3c
chore: add changelog fragment for blackhole sink rate limiting fix
pront Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/24188_blackhole_sink_rate_limiting.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The `blackhole` sink's periodic statistics messages (controlled by `print_interval_secs`) are no longer incorrectly suppressed by rate limiting. These informational messages now appear at the user-configured interval as expected.

authors: pront
2 changes: 2 additions & 0 deletions src/sinks/blackhole/sink.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ impl StreamSink<EventArray> for BlackholeSink {
info!(
events = total_events.load(Ordering::Relaxed),
raw_bytes_collected = total_raw_bytes.load(Ordering::Relaxed),
internal_log_rate_limit = false,
"Collected events."
);
},
Expand All @@ -75,6 +76,7 @@ impl StreamSink<EventArray> for BlackholeSink {
info!(
events = total_events.load(Ordering::Relaxed),
raw_bytes_collected = total_raw_bytes.load(Ordering::Relaxed),
internal_log_rate_limit = false,
"Collected events."
);
});
Expand Down
Loading