Skip to content

Swipe Up To Dismiss Can Prevent Scrolling #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brody2002 merged 1 commit into from
Feb 19, 2026
Merged

Swipe Up To Dismiss Can Prevent Scrolling #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sources/FlowStack/View+InteractiveDismiss.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@ class InteractiveDismissCoordinator: NSObject, ObservableObject, UIGestureRecogn
}

func gestureRecognizerShouldBegin(_ gestureRecognizer: UIGestureRecognizer) -> Bool {
guard gestureRecognizer == panGestureRecognizer, let scrollView = scrollView else { return true }
guard let scrollView = scrollView else { return true }
scrollView.isScrollEnabled = true
guard gestureRecognizer == panGestureRecognizer else { return true }

if panGestureRecognizer.translation(in: scrollView).y > 0 {
return scrollView.contentOffset.y - 5 <= -scrollView.contentInset.top
Expand All @@ -246,7 +248,6 @@ class InteractiveDismissCoordinator: NSObject, ObservableObject, UIGestureRecogn
}

func gestureRecognizer(_ gestureRecognizer: UIGestureRecognizer, shouldRecognizeSimultaneouslyWith otherGestureRecognizer: UIGestureRecognizer) -> Bool {

guard (gestureRecognizer == panGestureRecognizer || gestureRecognizer == panGestureRecognizer), let scrollView = scrollView else {
return true
}
Expand Down