Add image support to readFile via toModelOutput#22
Open
tomas-b wants to merge 1 commit intovercel-labs:mainfrom
Open
Add image support to readFile via toModelOutput#22tomas-b wants to merge 1 commit intovercel-labs:mainfrom
tomas-b wants to merge 1 commit intovercel-labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add image support to readFile via toModelOutput
Summary
readFilecurrently treats image files like text, which means models receivegarbled output instead of usable visual input.
This change adds image support to
readFileby detecting common image types,reading them as binary when the sandbox supports
readFileBuffer, and returningthem through
toModelOutputasimage-datacontent parts.Changes
readFileBuffer?to theSandboxinterfacereadFileBufferthrough the just-bash and Vercel sandbox adaptersreadFilemediaTypeimage-dataviatoModelOutputSupported image types
Compatibility
readFileBufferis optional, so existing custom sandboxes continue to workreadFileBufferis not implemented, image files fall back to the existing text pathTesting
{ data, mediaType }toModelOutputimage conversionreadFileBufferpnpm validatepasses