Skip to content

Pass 'data' attribute to endpoint on react/use-chat#1389

Closed
gaspar09 wants to merge 4 commits intomainfrom
gaspar/pass-data-react-use-chat
Closed

Pass 'data' attribute to endpoint on react/use-chat#1389
gaspar09 wants to merge 4 commits intomainfrom
gaspar/pass-data-react-use-chat

Conversation

@gaspar09
Copy link
Copy Markdown
Collaborator

No description provided.

@gaspar09 gaspar09 requested a review from MaxLeiter April 19, 2024 19:35
@gaspar09 gaspar09 force-pushed the gaspar/pass-data-react-use-chat branch from 5542ad7 to 800f28d Compare April 19, 2024 20:00
Comment thread .changeset/weak-students-tease.md Outdated
content,
tool_call_id,
...(name !== undefined && { name }),
...(data !== undefined && { data }),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to pass this on for messages, we'd need this to change in Svelte, Solid and Vue useChat as well.

@lgrammel
Copy link
Copy Markdown
Collaborator

lgrammel commented Jun 5, 2024

Superseeded by #1839

@lgrammel lgrammel closed this Jun 5, 2024
@lgrammel lgrammel deleted the gaspar/pass-data-react-use-chat branch July 2, 2025 10:48
gr2m added a commit that referenced this pull request Mar 23, 2026
Sync changes from vercel/workflow packages/ai/src/agent since Jan 30
(PR #12165 creation date):

- Add telemetry support via recordSpan wrapper around model.doStream()
  and new telemetry.ts module with OTel span recording
- Add normalizeFinishReason for cross-version compatibility (v5 string
  vs v6 { unified, raw } object)
- Fix prepareStep ordering: messages applied before system so system
  message isn't lost when messages replaces the prompt (#1389)
- Make DurableAgentOptions generic: tools/toolChoice properly typed
- Add prepareStep to DurableAgentOptions constructor for default
  step preparation across all stream() calls
- Add TelemetrySettings.recordInputs/recordOutputs options
- Add InferDurableAgentTools/InferDurableAgentUIMessage type helpers
- Update sendStart docstring explaining when to set false
- Pass telemetry through to executeTool calls

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gr2m added a commit that referenced this pull request Mar 23, 2026
## Summary

Syncs DurableAgent code with changes from
[vercel/workflow](https://github.com/vercel/workflow/tree/main/packages/ai/src/agent)
since PR #12165 was opened (Jan 30, 2026). Key workflow PRs
incorporated:

- [#1362](vercel/workflow#1362) — AI SDK v6
migration, compat tests
- [#1385](vercel/workflow#1385) — Various
compatibility fixes
- [#1389](vercel/workflow#1389) — Fix
prepareStep system message lost when messages also returned
- [#1329](vercel/workflow#1329) — Client-side
tools support

## Changes

- **Telemetry**: Add `recordSpan` wrapper around `model.doStream()` with
OTel span attributes (provider, model, generation settings). New
`telemetry.ts` module with lazy OTel API loading.
- **`normalizeFinishReason`**: Handle both v5 string (`'stop'`) and v6
object (`{ unified: 'stop', raw: 'stop' }`) finish reason formats
- **prepareStep ordering fix**: Apply `messages` override before
`system` so the system message isn't lost when messages replaces the
prompt
- **Generic `DurableAgentOptions<TTools>`**: Tools and toolChoice
properly typed through the generic parameter
- **Constructor `prepareStep`**: New field on `DurableAgentOptions` for
default step preparation across all `stream()` calls
- **`TelemetrySettings`**: Add `recordInputs`/`recordOutputs` options
- **Type helpers**: Export `InferDurableAgentTools` and
`InferDurableAgentUIMessage`
- **`sendStart` docs**: Explain when to set `false` (custom pre-stream
UIMessageChunks)
- **Telemetry threading**: Pass telemetry settings through to
`executeTool` calls

## Test plan

- [x] `pnpm type-check` — zero production code errors
- [x] `pnpm check` — lint passes
- [x] `pnpm build` in packages/durable-agent — builds
- [x] `pnpm test:node` in packages/durable-agent — 60 passed, 22
expected fail (same as before)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gr2m added a commit that referenced this pull request Mar 24, 2026
## Summary

Syncs DurableAgent code with changes from
[vercel/workflow](https://github.com/vercel/workflow/tree/main/packages/ai/src/agent)
since PR #12165 was opened (Jan 30, 2026). Key workflow PRs
incorporated:

- [#1362](vercel/workflow#1362) — AI SDK v6
migration, compat tests
- [#1385](vercel/workflow#1385) — Various
compatibility fixes
- [#1389](vercel/workflow#1389) — Fix
prepareStep system message lost when messages also returned
- [#1329](vercel/workflow#1329) — Client-side
tools support

## Changes

- **Telemetry**: Add `recordSpan` wrapper around `model.doStream()` with
OTel span attributes (provider, model, generation settings). New
`telemetry.ts` module with lazy OTel API loading.
- **`normalizeFinishReason`**: Handle both v5 string (`'stop'`) and v6
object (`{ unified: 'stop', raw: 'stop' }`) finish reason formats
- **prepareStep ordering fix**: Apply `messages` override before
`system` so the system message isn't lost when messages replaces the
prompt
- **Generic `DurableAgentOptions<TTools>`**: Tools and toolChoice
properly typed through the generic parameter
- **Constructor `prepareStep`**: New field on `DurableAgentOptions` for
default step preparation across all `stream()` calls
- **`TelemetrySettings`**: Add `recordInputs`/`recordOutputs` options
- **Type helpers**: Export `InferDurableAgentTools` and
`InferDurableAgentUIMessage`
- **`sendStart` docs**: Explain when to set `false` (custom pre-stream
UIMessageChunks)
- **Telemetry threading**: Pass telemetry settings through to
`executeTool` calls

## Test plan

- [x] `pnpm type-check` — zero production code errors
- [x] `pnpm check` — lint passes
- [x] `pnpm build` in packages/durable-agent — builds
- [x] `pnpm test:node` in packages/durable-agent — 60 passed, 22
expected fail (same as before)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants