Closed
Conversation
lgrammel
reviewed
Apr 3, 2025
| 'delay 10', | ||
| { | ||
| textDelta: 'line \n\n', | ||
| textDelta: 'line \n\n ', |
Collaborator
There was a problem hiding this comment.
this will create an additional delay
lgrammel
reviewed
Apr 3, 2025
Comment on lines
+8
to
+10
| character: /(?!\s)(?=.)/g, | ||
| word: /[\u4E00-\u9FFF\u3040-\u309F\u30A0-\u30FF]|\s+/gm, | ||
| line: /\r\n|\r|\n/g, |
Collaborator
There was a problem hiding this comment.
what will happen to custom user regexp?
Contributor
Author
There was a problem hiding this comment.
i'll add more tests for custom chunking
Collaborator
|
This seems very complex, unclear to me if this complexity is needed. |
lgrammel
reviewed
Apr 3, 2025
Collaborator
|
This breaks/changes the current behavior - might be okay but I wonder if there's something simpler we can do. |
Collaborator
|
@samdenty I think overall I'd like to understand what the simplest thing is that we could do to support kanjii etc, vs revamping the whole algorithm. |
Contributor
Author
|
closing in favour of #5548 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integrates the custom text-splitter API I created in react-ai-flow, for better handling of splitted elements.
Features:
Spaces are always trailing on the last element, the regex is created over the whole string so you can use lookahead
Closes #5231