feat (core): Add finishReason field to NoObjectGeneratedError#5541
Merged
lgrammel merged 3 commits intovercel:mainfrom Apr 4, 2025
Merged
Conversation
BramMeerten
force-pushed
the
add-finish-reason-to-no-object-generated-error
branch
3 times, most recently
from
11d4c7e to
3c39f33
Compare
BramMeerten
changed the title
lgrammel
changed the title
Collaborator
|
Please add a patch changeset for |
indicate why an error such as JsonParseError occured, for example if finishReason is 'length' because max token size has been reached.
BramMeerten
force-pushed
the
add-finish-reason-to-no-object-generated-error
branch
from
3c39f33 to
3c1d40b
Compare
Contributor
Author
|
Oke, I updated the commit. |
lgrammel
reviewed
Apr 4, 2025
lgrammel
approved these changes
Apr 4, 2025
BramMeerten
force-pushed
the
add-finish-reason-to-no-object-generated-error
branch
from
920b44a to
e7f0e59
Compare
lgrammel
pushed a commit
that referenced
this pull request
Apr 4, 2025
Co-authored-by: Bram Meerten <bram.meerten@acagroup.be>
jacobkerber
pushed a commit
to jacobkerber/ai
that referenced
this pull request
Jul 15, 2025
…#5541) Co-authored-by: Bram Meerten <bram.meerten@acagroup.be>
jacobkerber
pushed a commit
to jacobkerber/ai
that referenced
this pull request
Jul 15, 2025
…#5541) Co-authored-by: Bram Meerten <bram.meerten@acagroup.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
finishReasonfield toNoObjectGeneratedError, this can help clarify why an error occurred.causeis not always enough to determine the exact reason.For example if the max token size was reached, the (JSON) response will be incomplete.
causewill be aJSONParseError, but the root cause is the token size which has been reached.By adding
finishReason(which info is already available where we throw the error) we can see that the value is 'length' and that the max token size has been reached.