Skip to content

Comments

fix(provider-utils): fix SSE parser bug (CRLF) (#6197)#6200

Merged
lgrammel merged 2 commits intov5from
lg/rlMuTqNs
May 7, 2025
Merged

fix(provider-utils): fix SSE parser bug (CRLF) (#6197)#6200
lgrammel merged 2 commits intov5from
lg/rlMuTqNs

Conversation

@lgrammel
Copy link
Collaborator

@lgrammel lgrammel commented May 7, 2025

Background

The below MCP SSE message will make the stream reader timeout.

data: /message?sessionId=123\r\nevent: endpoint

Summary

Fix the splitLines parser issue. The CRLF pointer was incorrectly implemented.

## Background

The below MCP SSE message will make the stream reader timeout.  
```
data: /message?sessionId=123\r\nevent: endpoint
```

## Summary

Fix the `splitLines` parser issue. The CRLF pointer was incorrectly
implemented.
@lgrammel lgrammel merged commit 87b828f into v5 May 7, 2025
8 checks passed
@lgrammel lgrammel deleted the lg/rlMuTqNs branch May 7, 2025 12:12
iteratetograceness pushed a commit to iteratetograceness/ai that referenced this pull request May 9, 2025
…6200)

## Background

The below MCP SSE message will make the stream reader timeout.  
```
data: /message?sessionId=123\r\nevent: endpoint
```

## Summary

Fix the `splitLines` parser issue. The CRLF pointer was incorrectly
implemented.

Co-authored-by: Wei-Chieh Hsia <passion804222@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants