Merged
Conversation
shaper
approved these changes
May 30, 2025
|
A few considerations: Testing: The checklist indicates that tests haven't been added yet—ensuring proper validation before merging might help catch any unexpected issues. Typed Provider Options: The future work notes suggest passing all provider options into the request body for now. Defining typed options could make integrations cleaner and reduce runtime errors. Formatting & Documentation: Since formatting fixes (pnpm prettier-fix) and documentation updates are included, it seems like the commit is well-prepared in terms of maintainability. |
dancer
pushed a commit
that referenced
this pull request
Jun 5, 2025
## Background Fal added support for new Flux Kontext models. ## Summary Adds model ids, example, and updates docs. ## Tasks - [ ] Tests have been added / updated (for bug fixes / features) - [x] Documentation has been added / updated (for bug fixes / features) - [x] A _patch_ changeset for relevant packages has been added (for bug fixes / features - run `pnpm changeset` in the project root) - [x] Formatting issues have been fixed (run `pnpm prettier-fix` in the project root) ## Future Work We might want to add typed provider options here. Currently just pass through the entire provider options into the body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Fal added support for new Flux Kontext models.
Summary
Adds model ids, example, and updates docs.
Tasks
pnpm changesetin the project root)pnpm prettier-fixin the project root)Future Work
We might want to add typed provider options here. Currently just pass through the entire provider options into the body.