fix(ai): Unexpected reasoning-start event in extract reasoning middleware#7107
Merged
lgrammel merged 1 commit intovercel:mainfrom Jul 8, 2025
Merged
Conversation
lgrammel
reviewed
Jul 8, 2025
Comment on lines
+700
to
704
| "id": "1", | ||
| "providerMetadata": undefined, | ||
| "text": "</think>", | ||
| "type": "text", | ||
| }, |
Collaborator
There was a problem hiding this comment.
(wondering if there is another bug hidden here)
Contributor
Author
There was a problem hiding this comment.
According to this test case and fix, when startWithReasoning equals false, only one reasoning-start event should be sent. Theoretically, there shouldn't be any bug.
lgrammel
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
If the extract reasoning middleware is used when making a request but the model's response does not include
<think></think>tags, the middleware will generate an unexpected reasoning-start event.Summary
Ensure that the reasoning-start event is only emitted in real reasoning mode.
Tasks
pnpm changesetin the project root)pnpm prettier-fixin the project root)