docs: exposes types and updates example apps for beforeSend #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/astro@4.10.0 |
feugy
force-pushed
the
damien/log-827-deploy-route-support-for-other-framework-docs
branch
from
29f5994 to
06b8bb7
Compare
tobiaslins
approved these changes
Nov 8, 2024
feugy
deleted the
damien/log-827-deploy-route-support-for-other-framework-docs
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖖 What's in there?
As part of documenting route support, this PR:
BeforeSendandBeforeSendEvent🤺 How to test?
On preview deployments, with console open, you will see relevant logs before sending page views.
🔬Notes to reviewers
apps/astro/src/components/BaseHead.astrowas unused, I've removed it, and I've moved Sveltekit layout from js to ts.The way in Astro to pass
beforeSendis by exposing a global function (we do the same in SpeedInsights, there's no built-in support for non-serializable props in Astro).