Skip to content

refactor(slack): share provider helpers #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dancer merged 2 commits into from
May 26, 2026
Merged

refactor(slack): share provider helpers #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f25d365
refactor(slack): share provider helpers
dancer May 26, 2026
8fee079
chore: add changeset
dancer May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strict-moons-sneeze.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@chat-adapter/slack": patch
---

reuse low-level Slack formatting helpers in the adapter
5 changes: 1 addition & 4 deletions packages/adapter-slack/src/blocks/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { markdownBoldToSlackMrkdwn } from "../format";
import { SlackBlockError } from "./errors";
import { LIMITS } from "./limits";
import type {
Expand Down Expand Up @@ -453,10 +454,6 @@ function rawText(
};
}

function markdownBoldToSlackMrkdwn(text: string): string {
return text.replace(/\*\*(.+?)\*\*/g, "*$1*");
}

function mapButtonStyle(
style: SlackButtonStyle | undefined
): "danger" | "primary" | undefined {
Expand Down
11 changes: 3 additions & 8 deletions packages/adapter-slack/src/cards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import type {
TextElement,
} from "chat";
import { cardChildToFallbackText, tableElementToAscii } from "chat";
import { markdownBoldToSlackMrkdwn } from "./format";

/**
* Convert emoji placeholders in text to Slack format.
Expand Down Expand Up @@ -168,14 +169,8 @@ function convertChildToBlocks(
}
}

/** Convert standard Markdown formatting to Slack mrkdwn */
function markdownToMrkdwn(text: string): string {
// **bold** → *bold*
return text.replace(/\*\*(.+?)\*\*/g, "*$1*");
}

export function convertTextToBlock(element: TextElement): SlackBlock {
const text = markdownToMrkdwn(convertEmoji(element.content));
const text = markdownBoldToSlackMrkdwn(convertEmoji(element.content));
let formattedText = text;

// Apply style
Expand Down Expand Up @@ -437,7 +432,7 @@ export function convertFieldsToBlock(element: FieldsElement): SlackBlock {
// Add label and value as separate field items
fields.push({
type: "mrkdwn",
text: `*${markdownToMrkdwn(convertEmoji(field.label))}*\n${markdownToMrkdwn(convertEmoji(field.value))}`,
text: `*${markdownBoldToSlackMrkdwn(convertEmoji(field.label))}*\n${markdownBoldToSlackMrkdwn(convertEmoji(field.value))}`,
});
}

Expand Down
41 changes: 9 additions & 32 deletions packages/adapter-slack/src/markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,9 @@ import {
stringifyMarkdown,
tableToAscii,
} from "chat";
import { linkBareSlackMentions, slackMrkdwnToMarkdown } from "./format";

// Match bare @mentions (e.g. "@george") to rewrite as Slack's `<@george>`.
// The lookbehind excludes `<` (already-formatted mentions like `<@U123>`) and
// any word character, so email addresses like `user@example.com` are left alone.
const BARE_MENTION_REGEX = /(?<![<\w])@(\w+)/g;
const BARE_MENTION_PATTERN = /(?<![<\w])@(\w+)/g;

export type SlackTextPayload = { text: string } | { markdown_text: string };

Expand All @@ -53,32 +51,7 @@ export class SlackFormatConverter extends BaseFormatConverter {
* Parse Slack mrkdwn into an AST. Used for incoming `message` events.
*/
toAst(mrkdwn: string): Root {
let markdown = mrkdwn;

// User mentions: <@U123|name> -> @name or <@U123> -> @U123
markdown = markdown.replace(/<@([A-Z0-9_]+)\|([^<>]+)>/g, "@$2");
markdown = markdown.replace(/<@([A-Z0-9_]+)>/g, "@$1");

// Channel mentions: <#C123|name> -> #name
markdown = markdown.replace(/<#[A-Z0-9_]+\|([^<>]+)>/g, "#$1");
markdown = markdown.replace(/<#([A-Z0-9_]+)>/g, "#$1");

// Links: <url|text> -> [text](url)
markdown = markdown.replace(
/<(https?:\/\/[^|<>]+)\|([^<>]+)>/g,
"[$2]($1)"
);

// Bare links: <url> -> url
markdown = markdown.replace(/<(https?:\/\/[^<>]+)>/g, "$1");

// Bold: *text* -> **text** (Slack uses single * for bold)
markdown = markdown.replace(/(?<![_*\\])\*([^*\n]+)\*(?![_*])/g, "**$1**");

// Strikethrough: ~text~ -> ~~text~~
markdown = markdown.replace(/(?<!~)~([^~\n]+)~(?!~)/g, "~~$1~~");

return parseMarkdown(markdown);
return parseMarkdown(slackMrkdwnToMarkdown(mrkdwn));
}

/**
Expand Down Expand Up @@ -136,7 +109,7 @@ export class SlackFormatConverter extends BaseFormatConverter {

private finalize(text: string): string {
return convertEmojiPlaceholders(
text.replace(BARE_MENTION_REGEX, "<@$1>"),
linkBareMentionNames(linkBareSlackMentions(text)),
"slack"
);
}
Expand All @@ -155,7 +128,7 @@ export class SlackFormatConverter extends BaseFormatConverter {
}

if (isTextNode(node)) {
return node.value.replace(BARE_MENTION_REGEX, "<@$1>");
return linkBareMentionNames(linkBareSlackMentions(node.value));
}

if (isStrongNode(node)) {
Expand Down Expand Up @@ -219,3 +192,7 @@ export class SlackFormatConverter extends BaseFormatConverter {
return this.defaultNodeToText(node, (child) => this.nodeToMrkdwn(child));
}
}

function linkBareMentionNames(text: string): string {
return text.replace(BARE_MENTION_PATTERN, "<@$1>");
}