WIP: Per-source minification (DO NOT MERGE)#115
Closed
guybedford wants to merge 3 commits into
Closed
Conversation
983d0cd to
3c10c37
Compare
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 77.29% 77.64% +0.34%
==========================================
Files 11 12 +1
Lines 511 519 +8
==========================================
+ Hits 395 403 +8
Misses 116 116
Continue to review full report at Codecov.
|
29e3efb to
1bc6261
Compare
Contributor
|
Yeah so hacking those outputs would be very breaking when trying to upgrade webpack. However it's not like webpack's current output is the biggest part of minification work, so it makes sense to not minify those parts. |
Member
|
This might be an interesting source if you looking for performance vs size tradeoffs too: https://github.com/terser-js/terser#terser-fast-minify-mode |
Contributor
Author
Merged
df9444c to
b0a6294
Compare
b0a6294 to
d7010a7
Compare
d7010a7 to
345d81e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a proof of concept towards caching for minification in #46.
Because minification is done per-source, the output currently looks like:
It could be possible to hack the various webpack outputs to reduce the gaps here, but it definitely would be quite a hack.
The benefit at the end of the day would be per-source minification caching which would significantly speed up builds with minification.
Let me know if this seems like a worthwhile direction to continue along.