chore: windows ci#691
Conversation
|
Perhaps try updating the version of |
|
@guybedford Bumping node-gyp helped but now jest doesn't run. Seems like we need to expose GC and make it windows compatible in order to run the tests. |
| "build-test-binary": "cd test/binary && node-gyp rebuild && cp build/Release/hello.node ../integration/hello.node", | ||
| "codecov": "codecov", | ||
| "test": "node --expose-gc --max_old_space_size=3072 node_modules/.bin/jest", | ||
| "test-coverage": "node --expose-gc --max_old_space_size=3072 node_modules/.bin/jest --coverage --globals \"{\\\"coverage\\\":true}\" && codecov", |
There was a problem hiding this comment.
--max_old_space_size is necessary here.
There was a problem hiding this comment.
Thanks! I added cross-env and that got past the memory issue, but now jest doesn't find any tests on Windows 🤔
|
Seems like it might have something to do with the first CI reports: While the matcher configuration has: Try simplifying the rule to just: |
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
=======================================
Coverage 73.41% 73.41%
=======================================
Files 13 13
Lines 474 474
=======================================
Hits 348 348
Misses 126 126 Continue to review full report at Codecov.
|
|
@guybedford Good call! Looks like some of the tests are failing because windows emits However, there are a couple that look like actual bugs: https://github.com/vercel/ncc/pull/691/checks?check_run_id=2333639573#step:9:318 |
|
Fixed in #896 |
Related to #689