Using next.js with victory.js issue

[alikhani]

Trying out next with victory and getting stuck in an infinite error loop.

My page code looks like:

import { VictoryBar } from 'victory'

export default () => (
  <div>
    <VictoryBar />
  </div>
)

Running chrome on mac

[sedubois]

Which version of Next?
Have you got code to reproduce the issue?

[alikhani]

I'm on the latest beta..
Here is an example: https://github.com/alikhani/next-victory

[cia48621793]

I was able to reproduce this problem:

TypeError: Cannot read property 'props' of undefined

Seems more like a problem on the client side

[alikhani]

The issue seems to be a combination of both.
I've used victory with react-boilerplate before and haven't had any issues. Filed an issue there too: #516

next.js shouldn't get stuck in an error loop, even if the issue is in victory..

[arunoda]

This seems like an issue in our patch-react.js

[boygirl]

Victory uses an inheritance inversion pattern to enhance components. I think that's what's not playing nicely with Next. I believe Radium uses this pattern as well. Let me know if there's something simple that can be done in Victory to ease the friction.

[arunoda]

Actually, it's because we are patching react.
But now we are going to remove it.
See: #1420

[arunoda]

@alikhani We released a new beta.
Try now with the latest beta.

[alikhani]

Yes works good now. Great job!