Error was not caught ReferenceError: require is not defined with 7.0

[joaogarin]

Examples bug report

Example name

With apollo

Describe the bug

VM64:37 Error was not caught ReferenceError: require is not defined
at Module../node_modules/graphql/jsutils/instanceOf.mjs (instanceOf.mjs:31)

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

1. Go to https://github.com/zeit/next.js/tree/canary/examples/with-apollo
2. clone and npm install
3. Launch site on http://localhost:3000
4. See error

I can imagine other apollo examples also have the same issue after 7.x

Expected behavior

No errors.

Screenshots

System information

• OS: [macOS]
• Browser (if applies) [e.g. chrome, safari]
• Version of Next.js: [e.g. 7.0.0]

Additional context

Only happens when trying out 7.0. It seems related to webpack4 and the support on .mjs files..it could be also an issue with graphql-js, I cant really find anything there. maybe someone else can help finding this out..will gladly move issue there if thats the case. Also dont know if at this point 7.0 is stable..just wanted to see how bad an upgrade would be, probably still a bit soon for me ;)

[amytych]

I solved it by updating graphql, it's quite outdated in this example. I sent a PR #5242 to fix it.

[joaogarin]

awesome, yeah I though graphql dependency was coming from react-apollo, but y that totally works tks 👍 cheers

[alexindigo]

We had exactly same issue, and upgrading graphql version didn't help (at first), so we spent quite some time investigating, until we've found that one of the dependency of our dependency had it's own copy of graphql that was older version – that package had graphql as dependency instead of listing it as peerDependency. After it was fixed everything went back to normal.

In case anybody else would be struggling with the same issue.

[ofarukcaki]

I don't have graphql but still I get the error