remove mkdirp, bump fs-extra to 9.0.0 by dulmandakh · Pull Request #11251 · vercel/next.js

dulmandakh · 2020-03-21T04:28:31Z

This PR started to fix mkdirp deprecation warning, but ended up removing mkdirp and bumping fs-extra to 9.0.0 (requires node 10 too, see https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md). As next raised node.js requirement to 10, we can create directories recursively using fs.mkdir, so there is no need of mkdirp. Also the root project depended on mkdir, while fs-extra provided mkdirp.

ijjk · 2020-03-21T04:44:28Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
buildDuration	9.7s	9.6s	-67ms
nodeModulesSize	53.3 MB	53.2 MB	-87.4 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
index.html gzip	916 B	916 B	✓
link.html gzip	924 B	924 B	✓
withRouter.html gzip	913 B	913 B	✓
Overall change	2.75 kB	2.75 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
buildDuration	10.3s	10.8s	⚠️ +522ms
nodeModulesSize	53.3 MB	53.2 MB	-87.4 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_error.js gzip	293 kB	293 kB	-536 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	956 B	956 B	✓
index.js gzip	294 kB	293 kB	-156 B
link.js gzip	301 kB	301 kB	⚠️ +152 B
routerDirect.js gzip	299 kB	300 kB	⚠️ +680 B
withRouter.js gzip	300 kB	300 kB	⚠️ +76 B
Overall change	1.49 MB	1.49 MB	⚠️ +216 B

ijjk · 2020-03-21T05:09:08Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
buildDuration	11s	10.6s	-328ms
nodeModulesSize	53.3 MB	53.2 MB	-87.4 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
index.html gzip	916 B	916 B	✓
link.html gzip	924 B	924 B	✓
withRouter.html gzip	913 B	913 B	✓
Overall change	2.75 kB	2.75 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
buildDuration	12.3s	11.5s	-757ms
nodeModulesSize	53.3 MB	53.2 MB	-87.4 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_error.js gzip	293 kB	294 kB	⚠️ +386 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	956 B	956 B	✓
index.js gzip	293 kB	293 kB	⚠️ +399 B
link.js gzip	301 kB	301 kB	-82 B
routerDirect.js gzip	300 kB	300 kB	⚠️ +73 B
withRouter.js gzip	300 kB	300 kB	-69 B
Overall change	1.49 MB	1.49 MB	⚠️ +707 B

ijjk · 2020-03-21T05:26:37Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
buildDuration	9.9s	9.9s	-69ms
nodeModulesSize	53.3 MB	53.2 MB	-108 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
index.html gzip	916 B	916 B	✓
link.html gzip	924 B	924 B	✓
withRouter.html gzip	913 B	913 B	✓
Overall change	2.75 kB	2.75 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
buildDuration	11s	11.1s	⚠️ +102ms
nodeModulesSize	53.3 MB	53.2 MB	-108 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	dulmandakh/next.js mkdirp-1.0.3	Change
_error.js gzip	294 kB	293 kB	-778 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	956 B	956 B	✓
index.js gzip	294 kB	293 kB	-1.21 kB
link.js gzip	301 kB	301 kB	-494 B
routerDirect.js gzip	300 kB	300 kB	⚠️ +3 B
withRouter.js gzip	300 kB	300 kB	-135 B
Overall change	1.49 MB	1.49 MB	-2.62 kB

timneutkens · 2020-03-21T16:02:01Z

Great PR 👍 Thanks!

bump mkdirp to 1.0.3, which support promise

a6e970c

dulmandakh requested review from Timer, ijjk, lfades and timneutkens as code owners March 21, 2020 04:28

fix mkdirp in spr-cache.ts

3896d17

bump fs-extra to 9.0.0

c53d47e

remove mkdirp

b801f47

dulmandakh changed the title ~~bump mkdirp to 1.0.3, which supports promise~~ remove mkdirp, bump fs-extra to 9.0.0 Mar 21, 2020

timneutkens approved these changes Mar 21, 2020

View reviewed changes

timneutkens merged commit d3fb262 into vercel:canary Mar 21, 2020

dulmandakh deleted the mkdirp-1.0.3 branch March 22, 2020 00:31

matamatanot mentioned this pull request Mar 22, 2020

Fixes security issues #11234

Closed

This was referenced Apr 13, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.4 yowainwright/Advanced-React#46

Merged

[Snyk] Upgrade next from 9.3.1 to 9.3.2 cds-snc/next-holidays#35

Closed

This was referenced Apr 22, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.3 zagrajmy/frontend#162

Merged

[Snyk] Upgrade next from 9.3.2 to 9.3.3 grouparoo/next-plugins-example#9

Closed

[Snyk] Upgrade next from 9.3.2 to 9.3.3 GreyWolfLab/devPortal#3

Open

matamatanot mentioned this pull request Sep 12, 2020

Remove mkdirp from dependencies again #17042

Closed

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove mkdirp, bump fs-extra to 9.0.0#11251

remove mkdirp, bump fs-extra to 9.0.0#11251
timneutkens merged 4 commits into
vercel:canaryfrom
dulmandakh:mkdirp-1.0.3

dulmandakh commented Mar 21, 2020 •

edited

Loading

Uh oh!

ijjk commented Mar 21, 2020

Uh oh!

ijjk commented Mar 21, 2020

Uh oh!

ijjk commented Mar 21, 2020

Uh oh!

timneutkens commented Mar 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dulmandakh commented Mar 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ijjk commented Mar 21, 2020

Stats from current PR

Uh oh!

ijjk commented Mar 21, 2020

Stats from current PR

Uh oh!

ijjk commented Mar 21, 2020

Stats from current PR

Uh oh!

timneutkens commented Mar 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dulmandakh commented Mar 21, 2020 •

edited

Loading