Skip to content

remove assetPrefix in normalizeRoute fn#2002

Closed
tscanlin wants to merge 1 commit into
vercel:v3-betafrom
tscanlin:multiple-apps-domain
Closed

remove assetPrefix in normalizeRoute fn#2002
tscanlin wants to merge 1 commit into
vercel:v3-betafrom
tscanlin:multiple-apps-domain

Conversation

@tscanlin
Copy link
Copy Markdown
Contributor

This change makes it so you can easily serve multiple static next apps from subfolders on the same domain using the already available assetPrefix option.

Without this change the file that's requested is like:
/${assetPrefix}/_next/c0bae9f4-37d0-4f02-8a91-08fe02d6fbfb/page/${assetPrefix}/index.js

instead of:
/${assetPrefix}/_next/c0bae9f4-37d0-4f02-8a91-08fe02d6fbfb/page/index.js

like you'd want.

@arunoda
Copy link
Copy Markdown
Contributor

arunoda commented May 18, 2017

Serving Next.js apps from multiple directories is not a goal of Next.js at the moment.
So, I can't take this in.

@tscanlin
Copy link
Copy Markdown
Contributor Author

FWIW it seems that this fix solved the issue for multiple next apps on one domain: #257

It would be awesome if we could get this landed.

@wesbos
Copy link
Copy Markdown
Contributor

wesbos commented Jun 2, 2017

+1 for this - I'm trying to run Next though an express app to power my admin console.

@gcpantazis
Copy link
Copy Markdown
Contributor

gcpantazis commented Jun 13, 2017

#2186 would supercede this by making the _next directory directly configurable.

assetPrefix is more meant for CDN, if memory serves?

@dvakatsiienko
Copy link
Copy Markdown
Contributor

We are following the same approach with different next apps in nested pathes on the same domain. We need this functionality also!

@lock lock Bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants