Minimal dep upgrade - avoid alpha/beta, use the latest minor by chulkilee · Pull Request #20411 · vercel/next.js

chulkilee · 2020-12-23T04:30:30Z

Remove mkdirp (closes Remove mkdirp from dependencies again #17042)
@ampproject/toolbox-optimizer: 2.7.3=> 2.7.3
browserslist: 4.14.6 => 4.16.1
sass-loader: 10.0.5 => 10.1.1
watchpack: 2.0.0-beta.13 => 2.1.0
chokidar: 3.4.3 => 3.5.1
styled-jsx: 3.3.2 => 3.4.1
postcss: 8.1.7 => 8.2.4

(see links for changelog / releases)

I ran yarn && ./check-pre-compiled.sh after updating deps. Let me know if I need to something else!

ijjk · 2020-12-23T04:39:45Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
buildDuration	9.9s	10.3s	⚠️ +401ms
nodeModulesSize	82.6 MB	82.6 MB	-38 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.977	2.037	⚠️ +0.06
/ avg req/sec	1264.67	1227.21	⚠️ -37.46
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.227	1.261	⚠️ +0.03
/error-in-render avg req/sec	2037.1	1982.59	⚠️ -54.51

Client Bundles (main, webpack, commons)

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e0d2962..b163.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
index.html gzip	612 B	612 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
buildDuration	12.6s	12.2s	-411ms
nodeModulesSize	82.6 MB	82.6 MB	-38 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e0d2962..b163.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: 3c115605d58d24296089d6342e9cb097a758f72d

ijjk · 2021-01-19T13:35:12Z

Failing test suites

Commit: f4cade9

test/integration/amphtml-fragment-style/test/index.test.js

AMP Fragment Styles > adds styles from fragment in AMP mode correctly

Expand output

● AMP Fragment Styles › adds styles from fragment in AMP mode correctly

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Test suite failed to run

TypeError: Cannot read property '__app' of undefined

  316 | 
  317 | export async function stopApp(server) {
> 318 |   if (server.__app) {
      |              ^
  319 |     await server.__app.close()
  320 |   }
  321 |   await promiseCall(server, 'close')

  at stopApp (lib/next-test-utils.js:318:14)
  at integration/amphtml-fragment-style/test/index.test.js:32:18

test/integration/amphtml-custom-optimizer/test/index.test.js

AMP Custom Optimizer > should build and start for static page
AMP Custom Optimizer > should build and start for dynamic page

Expand output

● AMP Custom Optimizer › should build and start for static page

expect(received).toContain(expected) // indexOf

Expected substring: "amp-twitter width=\"500\" height=\"500\" layout=\"responsive\" data-tweetid=\"1159145442896166912\""
Received string:    "undefined"

  27 |     await killApp(app)
  28 | 
> 29 |     expect(html).toContain(
     |                  ^
  30 |       'amp-twitter width="500" height="500" layout="responsive" data-tweetid="1159145442896166912"'
  31 |     )
  32 |     expect(html).toContain('i-amphtml-version="001515617716922"')

  at Object.<anonymous> (integration/amphtml-custom-optimizer/test/index.test.js:29:18)

● AMP Custom Optimizer › should build and start for dynamic page

expect(received).toContain(expected) // indexOf

Expected substring: "amp-img width=\"500\" height=\"500\" layout=\"responsive\" src=\"https://amp.dev/static/samples/img/story_dog2_portrait.jpg\""
Received string:    "undefined"

  46 |     await killApp(app)
  47 | 
> 48 |     expect(html).toContain(
     |                  ^
  49 |       'amp-img width="500" height="500" layout="responsive" src="https://amp.dev/static/samples/img/story_dog2_portrait.jpg"'
  50 |     )
  51 |     expect(html).toContain('i-amphtml-version="001515617716922"')

  at Object.<anonymous> (integration/amphtml-custom-optimizer/test/index.test.js:48:18)

test/integration/amphtml-custom-validator/test/index.test.js

AMP Custom Validator > should build and start successfully
AMP Custom Validator > should run in dev mode successfully

Expand output

● AMP Custom Validator › should build and start successfully

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● AMP Custom Validator › should run in dev mode successfully

expect(received).not.toContain(expected) // indexOf

Expected substring: not "error"
Received string:        "warn  - You have enabled experimental feature(s).
warn  - Experimental features are not covered by semver, and may cause unexpected or broken application behavior. Use them at your own risk.

warn  - Amp Validation

/  error  The mandatory attribute '⚡' is missing in tag 'html'.                                         https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#required-markup
   error  The parent tag of tag 'html' is '$root', but it can only be '!doctype'.                       https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
   error  Tag or text which is only allowed inside the body section found outside of the body section.
   error  The mandatory tag 'html !doctype' is missing or incorrect.                                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
   error  The mandatory tag 'link rel=canonical' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
   error  The mandatory tag 'meta charset=utf-8' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
   error  The mandatory tag 'meta name=viewport' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
   error  The mandatory tag 'noscript enclosure for boilerplate' is missing or incorrect.               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
   error  The mandatory tag 'head > style[amp-boilerplate]' is missing or incorrect.                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
   error  The mandatory tag 'noscript > style[amp-boilerplate]' is missing or incorrect.                https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
   error  The mandatory tag 'amphtml engine script' is missing or incorrect.                            https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup

"

  44 |     await killApp(app)
  45 | 
> 46 |     expect(stderr).not.toContain('error')
     |                        ^
  47 |     expect(html).toContain('Hello from AMP')
  48 |   })
  49 | })

  at Object.<anonymous> (integration/amphtml-custom-validator/test/index.test.js:46:24)

test/integration/amp-export-validation/test/index.test.js

AMP Validation on Export > should have shown errors during build
AMP Validation on Export > should export AMP pages
AMP Validation on Export > shows AMP warning without throwing error
AMP Validation on Export > throws error on AMP error
AMP Validation on Export > shows warning and error when throwing error

Expand output

● AMP Validation on Export › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'img' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'\./
Received string:  "info  - Creating an optimized production build...
info  - Using external babel configuration from /home/runner/work/next.js/next.js/test/.babelrc
info  - Compiled successfully
info  - Collecting page data...
info  - Generating static pages (0/7)
info  - Generating static pages (1/7)
info  - Generating static pages (3/7)
info  - Generating static pages (5/7)
info  - Generating static pages (7/7)
Amp Validation·
/cat          error  The mandatory attribute '⚡' is missing in tag 'html'.                                         https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#required-markup
              error  The parent tag of tag 'html' is '$root', but it can only be '!doctype'.                       https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  Tag or text which is only allowed inside the body section found outside of the body section.
              error  The mandatory tag 'html !doctype' is missing or incorrect.                                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'link rel=canonical' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta charset=utf-8' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta name=viewport' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'noscript enclosure for boilerplate' is missing or incorrect.               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'head > style[amp-boilerplate]' is missing or incorrect.                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'noscript > style[amp-boilerplate]' is missing or incorrect.                https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'amphtml engine script' is missing or incorrect.                            https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup·
/dog-cat      error  The mandatory attribute '⚡' is missing in tag 'html'.                                         https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#required-markup
              error  The parent tag of tag 'html' is '$root', but it can only be '!doctype'.                       https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  Tag or text which is only allowed inside the body section found outside of the body section.
              error  The mandatory tag 'html !doctype' is missing or incorrect.                                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'link rel=canonical' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta charset=utf-8' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta name=viewport' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'noscript enclosure for boilerplate' is missing or incorrect.               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'head > style[amp-boilerplate]' is missing or incorrect.                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'noscript > style[amp-boilerplate]' is missing or incorrect.                https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'amphtml engine script' is missing or incorrect.                            https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup·
/dog          error  The mandatory attribute '⚡' is missing in tag 'html'.                                         https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#required-markup
              error  The parent tag of tag 'html' is '$root', but it can only be '!doctype'.                       https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  Tag or text which is only allowed inside the body section found outside of the body section.
              error  The mandatory tag 'html !doctype' is missing or incorrect.                                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'link rel=canonical' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta charset=utf-8' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta name=viewport' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'noscript enclosure for boilerplate' is missing or incorrect.               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'head > style[amp-boilerplate]' is missing or incorrect.                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'noscript > style[amp-boilerplate]' is missing or incorrect.                https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'amphtml engine script' is missing or incorrect.                            https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup·
/first        error  The mandatory attribute '⚡' is missing in tag 'html'.                                         https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#required-markup
              error  The parent tag of tag 'html' is '$root', but it can only be '!doctype'.                       https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  Tag or text which is only allowed inside the body section found outside of the body section.
              error  The mandatory tag 'html !doctype' is missing or incorrect.                                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'link rel=canonical' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta charset=utf-8' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta name=viewport' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'noscript enclosure for boilerplate' is missing or incorrect.               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'head > style[amp-boilerplate]' is missing or incorrect.                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'noscript > style[amp-boilerplate]' is missing or incorrect.                https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'amphtml engine script' is missing or incorrect.                            https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup·
/second       error  The mandatory attribute '⚡' is missing in tag 'html'.                                         https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#required-markup
              error  The parent tag of tag 'html' is '$root', but it can only be '!doctype'.                       https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  Tag or text which is only allowed inside the body section found outside of the body section.
              error  The mandatory tag 'html !doctype' is missing or incorrect.                                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'link rel=canonical' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta charset=utf-8' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta name=viewport' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'noscript enclosure for boilerplate' is missing or incorrect.               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'head > style[amp-boilerplate]' is missing or incorrect.                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'noscript > style[amp-boilerplate]' is missing or incorrect.                https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'amphtml engine script' is missing or incorrect.                            https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup·
/third?amp=1  error  The mandatory attribute '⚡' is missing in tag 'html'.                                         https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#required-markup
              error  The parent tag of tag 'html' is '$root', but it can only be '!doctype'.                       https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  Tag or text which is only allowed inside the body section found outside of the body section.
              error  The mandatory tag 'html !doctype' is missing or incorrect.                                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'link rel=canonical' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta charset=utf-8' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'meta name=viewport' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
              error  The mandatory tag 'noscript enclosure for boilerplate' is missing or incorrect.               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'head > style[amp-boilerplate]' is missing or incorrect.                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'noscript > style[amp-boilerplate]' is missing or incorrect.                https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
              error  The mandatory tag 'amphtml engine script' is missing or incorrect.                            https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup·
warn  - Detected next.config.js, no exported configuration found. https://err.sh/vercel/next.js/empty-configuration·
> Build error occurred
Error: AMP Validation caused the export to fail. https://err.sh/vercel/next.js/amp-export-validation

  28 | if(!options.buildExport&&prerenderManifest){await Promise.all(Object.keys(prerenderManifest.routes).map(async route=>{const{srcRoute}=prerenderManifest.routes[route];const pageName=srcRoute||route;const pagePath=(0,_require.getPagePath)(pageName,distDir,isLikeServerless);const distPagesDir=(0,_path.join)(pagePath,// strip leading / and then recurse number of nested dirs
  29 | // to place from base folder
> 30 | pageName.substr(1).split('/').map(()=>'..').join('/'));route=(0,_normalizePagePath.normalizePagePath)(route);const orig=(0,_path.join)(distPagesDir,route);const htmlDest=(0,_path.join)(outDir,`${route}${subFolders&&route!=='/index'?`${_path.sep}index`:''}.html`);const ampHtmlDest=(0,_path.join)(outDir,`${route}.amp${subFolders?`${_path.sep}index`:''}.html`);const jsonDest=(0,_path.join)(pagesDataDir,`${route}.json`);await _fs.promises.mkdir((0,_path.dirname)(htmlDest),{recursive:true});await _fs.promises.mkdir((0,_path.dirname)(jsonDest),{recursive:true});await _fs.promises.copyFile(`${orig}.html`,htmlDest);await _fs.promises.copyFile(`${orig}.json`,jsonDest);if(await exists(`${orig}.amp.html`)){await _fs.promises.mkdir((0,_path.dirname)(ampHtmlDest),{recursive:true});await _fs.promises.copyFile(`${orig}.amp.html`,ampHtmlDest);}}));}if(Object.keys(ampValidations).length){console.log((0,_index.formatAmpMessages)(ampValidations));}if(hadValidationError){throw new Error(`AMP Validation caused the export to fail. https://err.sh/vercel/next.js/amp-export-validation`);}if(renderError){throw new Error(`Export encountered errors on following paths:\n\t${errorPaths.sort().join('\n\t')}`);}(0,_fs.writeFileSync)((0,_path.join)(distDir,_constants2.EXPORT_DETAIL),JSON.stringify({version:1,outDirectory:outDir,success:true}),'utf8');if(telemetry){await telemetry.flush();}});}
     |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             ^
  31 | //# sourceMappingURL=index.js.map

  at ../packages/next/dist/export/index.js:30:973
  at ../async /home/runner/work/next.js/next.js/packages/next/dist/build/tracer.js:1:534
  at ../async /home/runner/work/next.js/next.js/packages/next/dist/build/index.js:39:69
  at ../async /home/runner/work/next.js/next.js/packages/next/dist/build/tracer.js:1:534
  at ../async /home/runner/work/next.js/next.js/packages/next/dist/build/index.js:21:712
  at ../async /home/runner/work/next.js/next.js/packages/next/dist/build/tracer.js:1:534
  "
  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:27:25)

● AMP Validation on Export › should export AMP pages

expect(received).toBe(expected) // Object.is equality

Expected: "PASS"
Received: "FAIL"

  16 |     }
  17 |   }
> 18 |   expect(result.status).toBe('PASS')
     |                         ^
  19 | }
  20 | 

  at validateAMP (lib/amp-test-utils.js:18:25)
  at integration/amp-export-validation/test/index.test.js:37:9
      at async Promise.all (index 0)
  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:34:5)

● AMP Validation on Export › shows AMP warning without throwing error

expect(received).toMatch(expected)

Expected pattern: /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
Received string:  "info  - using build directory: /home/runner/work/next.js/next.js/test/integration/amp-export-validation/.next
info  - Copying \"static build\" directory
info  - Launching 1 workers
info  - Exporting (0/3)
info  - Exporting (3/3)
Amp Validation·
/cat  error  The mandatory attribute '⚡' is missing in tag 'html'.                                         https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#required-markup
      error  The parent tag of tag 'html' is '$root', but it can only be '!doctype'.                       https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
      error  Tag or text which is only allowed inside the body section found outside of the body section.
      error  The mandatory tag 'html !doctype' is missing or incorrect.                                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
      error  The mandatory tag 'link rel=canonical' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
      error  The mandatory tag 'meta charset=utf-8' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
      error  The mandatory tag 'meta name=viewport' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
      error  The mandatory tag 'noscript enclosure for boilerplate' is missing or incorrect.               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
      error  The mandatory tag 'head > style[amp-boilerplate]' is missing or incorrect.                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
      error  The mandatory tag 'noscript > style[amp-boilerplate]' is missing or incorrect.                https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
      error  The mandatory tag 'amphtml engine script' is missing or incorrect.                            https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup·
"

  55 |         stderr: true,
  56 |       })
> 57 |       expect(stdout).toMatch(
     |                      ^
  58 |         /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
  59 |       )
  60 |       await expect(access(join(outDir, 'cat.html'))).resolves.toBe(undefined)

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:57:22)

● AMP Validation on Export › throws error on AMP error

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'img' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'\./
Received string:  "info  - using build directory: /home/runner/work/next.js/next.js/test/integration/amp-export-validation/.next
info  - Copying \"static build\" directory
info  - Launching 1 workers
info  - Exporting (0/3)
info  - Exporting (3/3)
Amp Validation·
/dog  error  The mandatory attribute '⚡' is missing in tag 'html'.                                         https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#required-markup
      error  The parent tag of tag 'html' is '$root', but it can only be '!doctype'.                       https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
      error  Tag or text which is only allowed inside the body section found outside of the body section.
      error  The mandatory tag 'html !doctype' is missing or incorrect.                                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
      error  The mandatory tag 'link rel=canonical' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
      error  The mandatory tag 'meta charset=utf-8' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
      error  The mandatory tag 'meta name=viewport' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
      error  The mandatory tag 'noscript enclosure for boilerplate' is missing or incorrect.               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
      error  The mandatory tag 'head > style[amp-boilerplate]' is missing or incorrect.                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
      error  The mandatory tag 'noscript > style[amp-boilerplate]' is missing or incorrect.                https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
      error  The mandatory tag 'amphtml engine script' is missing or incorrect.                            https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup·
"

  82 |         stderr: true,
  83 |       })
> 84 |       expect(stdout).toMatch(
     |                      ^
  85 |         /error.*The parent tag of tag 'img' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'\./
  86 |       )
  87 |       await expect(access(join(outDir, 'dog.html'))).resolves.toBe(undefined)

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:84:22)

● AMP Validation on Export › shows warning and error when throwing error

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'img' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'\./
Received string:  "info  - using build directory: /home/runner/work/next.js/next.js/test/integration/amp-export-validation/.next
info  - Copying \"static build\" directory
info  - Launching 1 workers
info  - Exporting (0/3)
info  - Exporting (3/3)
Amp Validation·
/dog-cat  error  The mandatory attribute '⚡' is missing in tag 'html'.                                         https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#required-markup
          error  The parent tag of tag 'html' is '$root', but it can only be '!doctype'.                       https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
          error  Tag or text which is only allowed inside the body section found outside of the body section.
          error  The mandatory tag 'html !doctype' is missing or incorrect.                                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
          error  The mandatory tag 'link rel=canonical' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
          error  The mandatory tag 'meta charset=utf-8' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
          error  The mandatory tag 'meta name=viewport' is missing or incorrect.                               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup
          error  The mandatory tag 'noscript enclosure for boilerplate' is missing or incorrect.               https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
          error  The mandatory tag 'head > style[amp-boilerplate]' is missing or incorrect.                    https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
          error  The mandatory tag 'noscript > style[amp-boilerplate]' is missing or incorrect.                https://amp.dev/documentation/guides-and-tutorials/learn/spec/amp-boilerplate/?format=websites
          error  The mandatory tag 'amphtml engine script' is missing or incorrect.                            https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup·
"

  109 |         stderr: true,
  110 |       })
> 111 |       expect(stdout).toMatch(
      |                      ^
  112 |         /error.*The parent tag of tag 'img' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'\./
  113 |       )
  114 |       await expect(access(join(outDir, 'dog-cat.html'))).resolves.toBe(

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:111:22)

test/integration/auto-export-query-error/test/index.test.js

Auto Export > server mode > should show warning for query provided for auto exported page correctly
Auto Export > serverless mode > should show warning for query provided for auto exported page correctly

Expand output

● Auto Export › server mode › should show warning for query provided for auto exported page correctly

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Auto Export › serverless mode › should show warning for query provided for auto exported page correctly

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

test/integration/export/test/index.test.js

Static Export > should delete existing exported files
Static Export > should honor exportTrailingSlash for 404 page
Static Export > should handle trailing slash in getStaticPaths
Static Export > should only output 404.html without exportTrailingSlash
Static Export > should not duplicate /index with exportTrailingSlash
Static Export > API routes export > Should throw if a route is matched
Static Export > Dynamic routes export > Should throw error not matched route
Static Export > ExportPathMap's query in development mode > should be present in ctx.query
Static Export > ExportPathMap's query in development mode > should replace url query params in ctx.query when conflicting
Static Export > ExportPathMap's query in development mode > should be merged with url query params in ctx.query
Static Export > Render in development mode > should render the home page
Static Export > Render in development mode > should render pages only existent in exportPathMap page
Static Export > Render via SSR > should render the home page
Static Export > Render via SSR > should render the about page
Static Export > Render via SSR > should render links correctly
Static Export > Render via SSR > should render a page with getInitialProps
Static Export > Render via SSR > should render a dynamically rendered custom url page
Static Export > Render via SSR > should render pages with dynamic imports
Static Export > Render via SSR > should render paths with extensions
Static Export > Render via SSR > should give empty object for query if there is no query
Static Export > Render via SSR > should render _error on 404.html even if not provided in exportPathMap
Static Export > Render via SSR > should render _error on /404/index.html
Static Export > Render via SSR > Should serve static files
Static Export > Render via SSR > Should serve public files
Static Export > Render via SSR > Should render dynamic files with query
Static Export > Render via browser > should render the home page
Static Export > Render via browser > should add trailing slash on Link
Static Export > Render via browser > should not add any slash on hash Link
Static Export > Render via browser > should preserve hash symbol on empty hash Link
Static Export > Render via browser > should preserve question mark on empty query Link
Static Export > Render via browser > should not add trailing slash on Link when disabled
Static Export > Render via browser > should do navigations via Link
Static Export > Render via browser > should do navigations via Router
Static Export > Render via browser > should do run client side javascript
Static Export > Render via browser > should render pages using getInitialProps
Static Export > Render via browser > should render dynamic pages with custom urls
Static Export > Render via browser > should support client side naviagtion
Static Export > Render via browser > should render dynamic import components in the client
Static Export > Render via browser > should render pages with url hash correctly
Static Export > Render via browser > should navigate even if used a button inside
Static Export > Render via browser > should update query after mount
Static Export > Render via browser > pages in the nested level: level1 > should render the home page
Static Export > Render via browser > pages in the nested level: level1 > should render the about page

Expand output

● Static Export › should delete existing exported files

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › should honor exportTrailingSlash for 404 page

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › should handle trailing slash in getStaticPaths

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › should only output 404.html without exportTrailingSlash

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › should not duplicate /index with exportTrailingSlash

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › should render the home page

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › should render the about page

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › should render links correctly

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › should render a page with getInitialProps

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › should render a dynamically rendered custom url page

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › should render pages with dynamic imports

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › should render paths with extensions

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › should give empty object for query if there is no query

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › should render _error on 404.html even if not provided in exportPathMap

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › should render _error on /404/index.html

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › Should serve static files

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › Should serve public files

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via SSR › Should render dynamic files with query

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should render the home page

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should add trailing slash on Link

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should not add any slash on hash Link

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should preserve hash symbol on empty hash Link

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should preserve question mark on empty query Link

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should not add trailing slash on Link when disabled

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should do navigations via Link

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should do navigations via Router

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should do run client side javascript

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should render pages using getInitialProps

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should render dynamic pages with custom urls

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should support client side naviagtion

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should render dynamic import components in the client

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should render pages with url hash correctly

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should navigate even if used a button inside

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › should update query after mount

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › pages in the nested level: level1 › should render the home page

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render via browser › pages in the nested level: level1 › should render the about page

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render in development mode › should render the home page

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Render in development mode › should render pages only existent in exportPathMap page

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › ExportPathMap's query in development mode › should be present in ctx.query

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › ExportPathMap's query in development mode › should replace url query params in ctx.query when conflicting

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › ExportPathMap's query in development mode › should be merged with url query params in ctx.query

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › Dynamic routes export › Should throw error not matched route

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Static Export › API routes export › Should throw if a route is matched

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Test suite failed to run

TypeError: Cannot read property '__app' of undefined

  316 | 
  317 | export async function stopApp(server) {
> 318 |   if (server.__app) {
      |              ^
  319 |     await server.__app.close()
  320 |   }
  321 |   await promiseCall(server, 'close')

  at stopApp (lib/next-test-utils.js:318:14)
  at integration/export/test/index.test.js:85:7

ijjk · 2021-01-19T13:40:23Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
buildDuration	8.5s	8.4s	-93ms
nodeModulesSize	77.6 MB	77.8 MB	⚠️ +212 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.683	1.666	-0.02
/ avg req/sec	1485.2	1500.43	+15.23
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.15	1.039	-0.11
/error-in-render avg req/sec	2174.37	2406.87	+232.5

Client Bundles (main, webpack, commons)

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
buildDuration	9.9s	9.6s	-253ms
nodeModulesSize	77.6 MB	77.8 MB	⚠️ +212 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
buildDuration	10.1s	10.5s	⚠️ +322ms
nodeModulesSize	77.6 MB	77.8 MB	⚠️ +222 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.69	1.666	-0.02
/ avg req/sec	1479.38	1500.79	+21.41
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.047	1.033	-0.01
/error-in-render avg req/sec	2387.27	2420.26	+32.99

Client Bundles (main, webpack, commons)

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
597-3bd7d6bd..868b.js gzip	13 kB	13 kB	✓
778-d412f8e7..3ee1.js gzip	6.56 kB	6.56 kB	✓
838-adcbad39..6e83.js gzip	31.1 kB	31.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-6a6a792..6877.js gzip	96 B	96 B	✓
webpack-e302..54e9.js gzip	954 B	954 B	✓
Overall change	91 kB	91 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
polyfills-a0..538c.js gzip	88 B	88 B	✓
Overall change	88 B	88 B	✓

Client Pages

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	chulkilee/next.js dep-upgrade-minimal	Change
index.html gzip	585 B	585 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "LdsUt9VGnfSFoS4lAgwON",
+        "buildId": "lS4B0j-pAfLzAhhA1ZRz9",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_buildManifest.js"
+      src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_ssgManifest.js"
+      src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "LdsUt9VGnfSFoS4lAgwON",
+        "buildId": "lS4B0j-pAfLzAhhA1ZRz9",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_buildManifest.js"
+      src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_ssgManifest.js"
+      src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "LdsUt9VGnfSFoS4lAgwON",
+        "buildId": "lS4B0j-pAfLzAhhA1ZRz9",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_buildManifest.js"
+      src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_ssgManifest.js"
+      src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: f4cade9

theoludwig

Great! It seems like the tests, and CI are failing unfortunately but I can't help...
I mostly interested in styled-jsx update.

timneutkens · 2021-01-25T15:13:45Z

Going to close this as it's stale, feel free to open a new PR and I'll review it!

Closes #17042 I removed mkdirp from package.json taskfil.js, and ran `yarn && ./check-pre-compiled.sh `. Please let me know if anything else is needed! (Extracted from #20411) Note that now compiled webpack has mkdirP function

chulkilee requested review from Timer, ijjk, lfades and timneutkens as code owners December 23, 2020 04:30

ijjk added the type: next label Dec 23, 2020

vercel Bot temporarily deployed to Preview December 23, 2020 04:30 Inactive

chulkilee added 3 commits January 19, 2021 22:06

Remove mkdirp

9887031

Update @ampproject/toolbox-optimizer to 2.7.3

b11a249

Upgrade prod dep of next to the next minor

f4cade9

chulkilee mentioned this pull request Jan 20, 2021

Remove mkdirp #21365

Merged

theoludwig suggested changes Jan 21, 2021

View reviewed changes

timneutkens closed this Jan 25, 2021

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minimal dep upgrade - avoid alpha/beta, use the latest minor#20411

Minimal dep upgrade - avoid alpha/beta, use the latest minor#20411
chulkilee wants to merge 3 commits into
vercel:canaryfrom
chulkilee:dep-upgrade-minimal

chulkilee commented Dec 23, 2020 •

edited

Loading

Uh oh!

ijjk commented Dec 23, 2020

Uh oh!

ijjk commented Jan 19, 2021 •

edited

Loading

Uh oh!

ijjk commented Jan 19, 2021

Diffs

Uh oh!

theoludwig left a comment •

edited

Loading

Uh oh!

timneutkens commented Jan 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

chulkilee commented Dec 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ijjk commented Dec 23, 2020

Stats from current PR

Uh oh!

ijjk commented Jan 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing test suites

Uh oh!

ijjk commented Jan 19, 2021

Stats from current PR

Diffs

Uh oh!

theoludwig left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timneutkens commented Jan 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chulkilee commented Dec 23, 2020 •

edited

Loading

ijjk commented Jan 19, 2021 •

edited

Loading

theoludwig left a comment •

edited

Loading