Skip to content

fix(docs): update width height value on example to sync with demo#64147

Merged
styfle merged 2 commits into
vercel:canaryfrom
hjick:fix/docs
Apr 8, 2024
Merged

fix(docs): update width height value on example to sync with demo#64147
styfle merged 2 commits into
vercel:canaryfrom
hjick:fix/docs

Conversation

@hjick
Copy link
Copy Markdown
Contributor

@hjick hjick commented Apr 6, 2024

I'm looking at the example code and demo for the Image component,
Responsive image using a static import and Responsive image with aspect ratio sections are immersive because the code in the example and the demo match, The Responsive image with fill section breaks the immersion because the code in the example and the demo are slightly different.

I think it's just a typo. It seems the width and height values are reversed.

Attach the code from the demo.

Responsive image with fill demo code�

@hjick hjick requested review from a team, huozhi, ijjk, shuding, styfle, timneutkens and ztanner as code owners April 6, 2024 16:43
@hjick hjick requested review from leerob and manovotny and removed request for a team April 6, 2024 16:43
@styfle styfle enabled auto-merge (squash) April 8, 2024 22:13
@styfle styfle merged commit baaca4b into vercel:canary Apr 8, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants