Skip to content

[dev-overlay] Remove unnecessary code from /pages dev error boundary #79983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 1 commit into from
Jun 4, 2025
Merged

[dev-overlay] Remove unnecessary code from /pages dev error boundary #79983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...s/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ export class PagesDevOverlayErrorBoundary extends React.PureComponent<
return { error }
}

componentDidCatch(error: Error) {
this.setState({ error })
}

// Explicit type is needed to avoid the generated `.d.ts` having a wide return type that could be specific to the `@types/react` version.
render(): React.ReactNode {
// The component has to be unmounted or else it would continue to error
Expand Down
4 changes: 1 addition & 3 deletions packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ export function PagesDevOverlay({ children }: PagesDevOverlayProps) {

return (
<>
<PagesDevOverlayErrorBoundary>
{children ?? null}
</PagesDevOverlayErrorBoundary>
<PagesDevOverlayErrorBoundary>{children}</PagesDevOverlayErrorBoundary>

{/* Fonts can only be loaded outside the Shadow DOM. */}
<FontStyles />
Expand Down
Loading