Skip to content

[test] Show decoded binary WebSocket messages in traces#91308

Merged
eps1lon merged 1 commit into
canaryfrom
sebbie/03-13-_test_show_decoded_binary_websocket_messages_in_traces
Mar 13, 2026
Merged

[test] Show decoded binary WebSocket messages in traces#91308
eps1lon merged 1 commit into
canaryfrom
sebbie/03-13-_test_show_decoded_binary_websocket_messages_in_traces

Conversation

@eps1lon
Copy link
Copy Markdown
Member

@eps1lon eps1lon commented Mar 13, 2026

Follow-up to #91266

Showing the Buffer is just noise. Now we print it decoded which shows us the Flight data from the debug channel:
CleanShot 2026-03-13 at 13 42 08@2x

I switched to just evaluating the string. It'll still show up in traces but won't show up in browser logs i.e. CI logs. Felt to spammy.

Copy link
Copy Markdown
Member Author

eps1lon commented Mar 13, 2026

@eps1lon eps1lon marked this pull request as ready for review March 13, 2026 12:58
@eps1lon eps1lon requested a review from unstubbable March 13, 2026 12:58
Base automatically changed from sebbie/03-12-_test_more_robust_instant-navs-devtools_actions_and_assertions to canary March 13, 2026 16:26
Copy link
Copy Markdown
Member Author

eps1lon commented Mar 13, 2026

Merge activity

  • Mar 13, 6:46 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 13, 6:47 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 13, 7:10 PM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'thank you, next', 'test integration (11/13) / build').

@eps1lon eps1lon force-pushed the sebbie/03-13-_test_show_decoded_binary_websocket_messages_in_traces branch from 45db1fd to d6ef9fb Compare March 13, 2026 18:47
@eps1lon eps1lon merged commit 156307e into canary Mar 13, 2026
286 of 288 checks passed
@eps1lon eps1lon deleted the sebbie/03-13-_test_show_decoded_binary_websocket_messages_in_traces branch March 13, 2026 20:11
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants